Changeset 91270 in webkit


Ignore:
Timestamp:
Jul 19, 2011 10:39:03 AM (13 years ago)
Author:
inferno@chromium.org
Message:

Source/WebCore: Crash when removing unrenderered nodes in replacement fragment.
​https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):

LayoutTests: Tests that we do not crash when removing unrendering nodes
in a replacement fragment.
​https://bugs.webkit.org/show_bug.cgi?id=64801

Reviewed by Ryosuke Niwa.

  • editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
  • editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r91269 r91270  
     12011-07-19  Abhishek Arya  <inferno@chromium.org>
     2
     3        Tests that we do not crash when removing unrendering nodes
     4        in a replacement fragment.
     5        https://bugs.webkit.org/show_bug.cgi?id=64801
     6
     7        Reviewed by Ryosuke Niwa.
     8
     9        * editing/pasteboard/replacement-fragment-remove-unrendered-node-crash-expected.txt: Added.
     10        * editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Added.
     11
    1122011-07-19  Rob Buis  <rbuis@rim.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r91269 r91270  
     12011-07-19  Abhishek Arya  <inferno@chromium.org>
     2
     3        Crash when removing unrenderered nodes in replacement fragment.
     4        https://bugs.webkit.org/show_bug.cgi?id=64801
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html
     9
     10        * editing/ReplaceSelectionCommand.cpp:
     11        (WebCore::ReplacementFragment::removeUnrenderedNodes):
     12
    1132011-07-19  Rob Buis  <rbuis@rim.com>
    214

  • trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp

    r90098 r91270  
    293293void ReplacementFragment::removeUnrenderedNodes(Node* holder)
    294294{
    295     Vector<Node*> unrendered;
     295    Vector<RefPtr<Node> > unrendered;
    296296
    297297    for (Node* node = holder->firstChild(); node; node = node->traverseNextNode(holder))
Note: See TracChangeset for help on using the changeset viewer.