Changeset 91273 in webkit

Timestamp:

Jul 19, 2011 11:21:52 AM (13 years ago)

Author:

rniwa@webkit.org

Message:

Buildbot marks a nrwt bot red when tests are missing results
​https://bugs.webkit.org/show_bug.cgi?id=64812

Reviewed by Tony Chang.

Added "missing results" label for tests that are missing results.

buildbot Now reports shows a label "X missing results" on a run when X tests were missing
expected results on that run.

Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/master.cfg (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

@@ -235 +235 @@
         incorrectLayoutLines = []
         expressions = {
-            'failed': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
-            'were flaky': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
+            'failures': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
+            'flakes': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
             'new passes': re.compile(r'Expected to .+, but passed:\s+\((\d+)\)'),
+            'missing results': re.compile(r'no expected results found\s*:\s+\((\d+)\)'),
         }
         testFailures = {}
@@ -313 +314 @@
         if self.incorrectLayoutLines:
             for line in self.incorrectLayoutLines:
-                if result != FAILURE and (line.find('were flaky') >= 0 or line.find('new passes') >= 0):
+                if line.find('flakes') >= 0 or line.find('new passes') >= 0 or line.find('missing results') >= 0:
                     result = WARNINGS
                 else:
-                    result = FAILURE
+                    return FAILURE
 
         return result

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Buildbot marks a nrwt bot red when tests are missing results
+        https://bugs.webkit.org/show_bug.cgi?id=64812
+
+        Reviewed by Tony Chang.
+
+        Added "missing results" label for tests that are missing results.
+
+        buildbot Now reports shows a label "X missing results" on a run when X tests were missing
+        expected results on that run.
+
+        Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
 2011-07-19  Adam Roben  <aroben@apple.com>