Changeset 91285 in webkit

Timestamp:

Jul 19, 2011 12:25:30 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

hover then un-hover makes state change
​https://bugs.webkit.org/show_bug.cgi?id=56401

Source/WebCore:

When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
block with inline children. If it is, then we should change the insertion point to the first child of the
anonymous block, otherwise the 'before' pseudo-element ends up in a different block.

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

Test: fast/dynamic/hover-before-position-after-style-change.html

• rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

Patch by Mihnea Ovidenie <​mihnea@adobe.com> on 2011-07-19
Reviewed by David Hyatt.

• fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
• fast/dynamic/hover-before-position-after-style-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt (added)
• LayoutTests/fast/dynamic/hover-before-position-after-style-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObjectChildList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-19  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        hover then un-hover makes state change
+        https://bugs.webkit.org/show_bug.cgi?id=56401
+
+        Reviewed by David Hyatt.
+
+        * fast/dynamic/hover-before-position-after-style-change-expected.txt: Added.
+        * fast/dynamic/hover-before-position-after-style-change.html: Added.
+
 2011-07-19  Gavin Barraclough  <barraclough@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-19  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        hover then un-hover makes state change
+        https://bugs.webkit.org/show_bug.cgi?id=56401
+
+        When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
+        block with inline children. If it is, then we should change the insertion point to the first child of the
+        anonymous block, otherwise the 'before' pseudo-element ends up in a different block.
+
+        Reviewed by David Hyatt.
+
+        Test: fast/dynamic/hover-before-position-after-style-change.html
+
+        * rendering/RenderObjectChildList.cpp:
+        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
+
 2011-07-19  Luke Macpherson   <macpherson@chromium.org>
 

trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

@@ -411 +411 @@
     
     RenderObject* insertBefore = (type == BEFORE) ? owner->virtualChildren()->firstChild() : 0;
+    if (insertBefore && insertBefore->isAnonymousBlock() && insertBefore->childrenInline()) {
+        // We are going to add the "before" element. We have to check whether the "insertBefore" element
+        // is an anonymous block with inline children. If it is, then we should insert the "before" element
+        // before the first inline child of the anonymous block, otherwise we will end up with the "before"
+        // element in a different block.
+        insertBefore = insertBefore->firstChild();
+    }
 
     // Generated content consists of a single container that houses multiple children (specified