Changeset 91305 in webkit

Timestamp:

Jul 19, 2011 2:51:34 PM (13 years ago)

Author:

barraclough@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=64809
REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)

Reviewed by Adam Roben.

I think this just needs new results. The test deliberately triggers a stack overflow,
and doesn't catch it, so the error is printed to the console. Previously RangeError
had the wrong prototype, and didn't convert the error into a useful error message,
printing a blank line in the console. Since r91116 we inherit from Error correctly,
and print the error to the console.

• fast/dom/error-to-string-stack-overflow-expected.txt:
• fast/js/script-tests/object-prototype-properties.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/dom/error-to-string-stack-overflow-expected.txt (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-19  Gavin Barraclough  <barraclough@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=64809
+        REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)
+
+        Reviewed by Adam Roben.
+
+        I think this just needs new results. The test deliberately triggers a stack overflow,
+        and doesn't catch it, so the error is printed to the console. Previously RangeError
+        had the wrong prototype, and didn't convert the error into a useful error message,
+        printing a blank line in the console. Since r91116 we inherit from Error correctly,
+        and print the error to the console.
+
+        * fast/dom/error-to-string-stack-overflow-expected.txt:
+        * fast/js/script-tests/object-prototype-properties.js:
+
 2011-07-19  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/fast/dom/error-to-string-stack-overflow-expected.txt

@@ -1 @@
-CONSOLE MESSAGE: line 17: 
+CONSOLE MESSAGE: line 17: RangeError: Maximum call stack size exceeded.
 Regression test for https://bugs.webkit.org/show_bug.cgi?id=30774. This test passes if it doesn't crash.