Changeset 91349 in webkit

Timestamp:

Jul 20, 2011 2:21:51 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r91285.
​http://trac.webkit.org/changeset/91285
​https://bugs.webkit.org/show_bug.cgi?id=64854

"Assertion hit in svg/custom/crash-textPath-attributes.html"
(Requested by mihnea on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2011-07-20

Source/WebCore:

• rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

• fast/dynamic/hover-before-position-after-style-change-expected.txt: Removed.
• fast/dynamic/hover-before-position-after-style-change.html: Removed.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt (deleted)
• LayoutTests/fast/dynamic/hover-before-position-after-style-change.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObjectChildList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r91285.
+        http://trac.webkit.org/changeset/91285
+        https://bugs.webkit.org/show_bug.cgi?id=64854
+
+        "Assertion hit in svg/custom/crash-textPath-attributes.html"
+        (Requested by mihnea on #webkit).
+
+        * fast/dynamic/hover-before-position-after-style-change-expected.txt: Removed.
+        * fast/dynamic/hover-before-position-after-style-change.html: Removed.
+
 2011-07-20  Boris Smus  <smus@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r91285.
+        http://trac.webkit.org/changeset/91285
+        https://bugs.webkit.org/show_bug.cgi?id=64854
+
+        "Assertion hit in svg/custom/crash-textPath-attributes.html"
+        (Requested by mihnea on #webkit).
+
+        * rendering/RenderObjectChildList.cpp:
+        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
+
 2011-07-20  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

@@ -411 +411 @@
     
     RenderObject* insertBefore = (type == BEFORE) ? owner->virtualChildren()->firstChild() : 0;
-    if (insertBefore && insertBefore->isAnonymousBlock() && insertBefore->childrenInline()) {
-        // We are going to add the "before" element. We have to check whether the "insertBefore" element
-        // is an anonymous block with inline children. If it is, then we should insert the "before" element
-        // before the first inline child of the anonymous block, otherwise we will end up with the "before"
-        // element in a different block.
-        insertBefore = insertBefore->firstChild();
-    }
 
     // Generated content consists of a single container that houses multiple children (specified