Changeset 91727 in webkit

Timestamp:

Jul 25, 2011 5:12:29 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

WebFrame should have a method to determine its visual emptiness
​https://bugs.webkit.org/show_bug.cgi?id=64223

Patch by Ian Henderson <​ianh@apple.com> on 2011-07-25
Reviewed by Dan Bernstein.

Source/WebCore:

• page/FrameView.h:

(WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
so we can tell whether it's visually non-empty.

Source/WebKit/mac:

• WebView/WebFrame.mm:

(-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
through WebKit.

• WebView/WebFramePrivate.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/FrameView.h (modified) (1 diff)
• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebFrame.mm (modified) (1 diff)
• WebKit/mac/WebView/WebFramePrivate.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-25  Ian Henderson  <ianh@apple.com>
+
+        WebFrame should have a method to determine its visual emptiness
+        https://bugs.webkit.org/show_bug.cgi?id=64223
+
+        Reviewed by Dan Bernstein.
+
+        * page/FrameView.h:
+        (WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
+        so we can tell whether it's visually non-empty.
+
 2011-07-25  Scott Graham  <scottmg@chromium.org>
 

trunk/Source/WebCore/page/FrameView.h

@@ -233 +233 @@
     void incrementVisuallyNonEmptyPixelCount(const IntSize&);
     void setIsVisuallyNonEmpty() { m_isVisuallyNonEmpty = true; }
+    bool isVisuallyNonEmpty() const { return m_isVisuallyNonEmpty; }
 
     void forceLayout(bool allowSubtree = false);

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2011-07-25  Ian Henderson  <ianh@apple.com>
+
+        WebFrame should have a method to determine its visual emptiness
+        https://bugs.webkit.org/show_bug.cgi?id=64223
+
+        Reviewed by Dan Bernstein.
+
+        * WebView/WebFrame.mm:
+        (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
+        through WebKit.
+        * WebView/WebFramePrivate.h:
+
 2011-07-19  Leo Yang  <leoyang.webkit@gmail.com>
 

trunk/Source/WebKit/mac/WebView/WebFrame.mm

@@ -914 +914 @@
 }
 
+- (BOOL)_isVisuallyNonEmpty
+{
+    if (FrameView* view = _private->coreFrame->view())
+        return view->isVisuallyNonEmpty();
+    return NO;
+}
+
 - (WebFrameLoadType)_loadType
 {

trunk/Source/WebKit/mac/WebView/WebFramePrivate.h

@@ -75 +75 @@
 - (BOOL)_isFrameSet;
 - (BOOL)_firstLayoutDone;
+- (BOOL)_isVisuallyNonEmpty;
 - (WebFrameLoadType)_loadType;