Changeset 91770 in webkit

Timestamp:

Jul 26, 2011 12:13:07 PM (13 years ago)

Author:

evan@chromium.org

Message:

regression: generating CSSValueKeywords should not print by default
​https://bugs.webkit.org/show_bug.cgi?id=65195

Reviewed by Tony Chang.

Some refactoring made some callers no longer pass the final 'beQuiet'
parameter to applyPreprocessor. This flag was only used to print the
input filename anyway, so remove the flag and just make the caller
print the filename if it wants this.

• bindings/scripts/IDLParser.pm:

(Parse): print before calling applyPreprocessor, if necessary.

• bindings/scripts/preprocessor.pm:

(applyPreprocessor): remove the beQuiet flag; just always be quiet.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/IDLParser.pm (modified) (1 diff)
• bindings/scripts/preprocessor.pm (modified) (2 diffs)
• css/make-css-file-arrays.pl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-26  Evan Martin  <evan@chromium.org>
+
+        regression: generating CSSValueKeywords should not print by default
+        https://bugs.webkit.org/show_bug.cgi?id=65195
+
+        Reviewed by Tony Chang.
+
+        Some refactoring made some callers no longer pass the final 'beQuiet'
+        parameter to applyPreprocessor.  This flag was only used to print the
+        input filename anyway, so remove the flag and just make the caller
+        print the filename if it wants this.
+
+        * bindings/scripts/IDLParser.pm:
+        (Parse): print before calling applyPreprocessor, if necessary.
+        * bindings/scripts/preprocessor.pm:
+        (applyPreprocessor): remove the beQuiet flag; just always be quiet.
+
 2011-07-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
 

trunk/Source/WebCore/bindings/scripts/IDLParser.pm

@@ -67 +67 @@
     $parentsOnly = shift;
 
-    my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor, $beQuiet);
+    print " | *** Starting to parse $fileName...\n |\n" unless $beQuiet;
+    my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor);
 
     my $dataAvailable = 0;

trunk/Source/WebCore/bindings/scripts/preprocessor.pm

@@ -40 +40 @@
     my $defines = shift;
     my $preprocessor = shift;
-    my $beQuiet = shift;
 
     if (!$preprocessor) {
@@ -59 +58 @@
     }
 
-    print " | *** Starting to parse $fileName...\n |\n" unless $beQuiet;
-
     my $pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), (map { "-D$_" } split(' ', $defines)), $fileName);
     close PP_IN;

trunk/Source/WebCore/css/make-css-file-arrays.pl

@@ -57 +57 @@
     } else {
         require preprocessor;
-        $text = join('', applyPreprocessor($in, $defines, $preprocessor, 1));
+        $text = join('', applyPreprocessor($in, $defines, $preprocessor));
     }