Changeset 91938 in webkit

Timestamp:

Jul 28, 2011 10:32:40 AM (13 years ago)

Author:

barraclough@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=65325
Performance tweak to parseInt

Reviewed by Oliver Hunt.

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseInt):

• parseInt applied to small positive numbers = floor.

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSGlobalObjectFunctions.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-07-28  Gavin Barraclough  <barraclough@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=65325
+        Performance tweak to parseInt
+
+        Reviewed by Oliver Hunt.
+
+        * runtime/JSGlobalObjectFunctions.cpp:
+        (JSC::globalFuncParseInt):
+            - parseInt applied to small positive numbers = floor.
+
 2011-07-28  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -461 +461 @@
 {
     JSValue value = exec->argument(0);
+
+    // Optimized case: If the argument is a positive number in the integer
+    // range, and the exponent is 10, then parseInt is equivalent to floor.
+    double n;
+    if (value.getNumber(n) && n >= 0 && n < INT_MAX && exec->argument(1).isUndefined())
+        return JSValue::encode(jsNumber(static_cast<int>(n)));
+
     int32_t radix = exec->argument(1).toInt32(exec);