Changeset 92133 in webkit

Timestamp:

Aug 1, 2011 11:45:02 AM (13 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic should show all failures, even ones that it can't find a regression range for
​https://bugs.webkit.org/show_bug.cgi?id=65447

Reviewed by Dimitri Glazkov.

Previously, we just wouldn't display test failures that we couldn't
identify a regression range for (or whose regression range had fallen
off the page). This patch just displays them at the end of the list,
which is slightly (but not much) better.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js

@@ -213 +213 @@
     var regressionRows = rowsInRevisionRange(impliedFirstFailingRevision, failureAnalysis.oldestFailingRevision);
 
-    // FIXME: We need to create more rows if regressionRows.length is zero.
-
     $('.entry', regressionRows).addClass('possible-regression');
 
     var failureSummary = ui.summarizeFailure(failureAnalysis).attr(config.kRevisionAttr, impliedFirstFailingRevision);
-    regressionRows.last().after(failureSummary);
+    (regressionRows.length ? regressionRows : $('.recent-history tr')).last().after(failureSummary);
 
     // FIXME: We should just compute this for failureSummary instead of recomputing the whole page.

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-01  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic should show all failures, even ones that it can't find a regression range for
+        https://bugs.webkit.org/show_bug.cgi?id=65447
+
+        Reviewed by Dimitri Glazkov.
+
+        Previously, we just wouldn't display test failures that we couldn't
+        identify a regression range for (or whose regression range had fallen
+        off the page).  This patch just displays them at the end of the list,
+        which is slightly (but not much) better.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
+
 2011-08-01  Jeff Miller  <jeffm@apple.com>