Changeset 92134 in webkit
- Timestamp:
- Aug 1, 2011 12:23:21 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 1 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html
r92056 r92134 33 33 <script src="base.js"></script> 34 34 <script src="Trac.js"></script> 35 <script src="builders.js"></script> 35 36 <script src="checkout.js"></script> 36 37 <script src="results.js"></script> -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
r92133 r92134 222 222 } 223 223 224 function showFailingBuildersInfobar(builderNameList) 225 { 226 if (builderNameList.length) 227 displayInfobar(ui.infobarMessageForCompileErrors(builderNameList), kBuildFailedInfobarType); 228 else 229 hideInfobarIfOfType(kBuildFailedInfobarType); 230 } 231 224 232 function update() 225 233 { 226 234 displayOnButterbar('Loading...'); 235 builders.buildersFailingStepRequredForTestCoverage(showFailingBuildersInfobar); 227 236 base.callInParallel([model.updateRecentCommits, model.updateResultsByBuilder], function() { 228 237 showRecentCommits(); -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js
r91677 r92134 452 452 }; 453 453 454 function isBuilderThatOnlyCompiles(builderName)455 {456 return config.kBuildersThatOnlyCompile.indexOf(builderName) != -1;457 }458 459 // FIXME: This method isn't tested because we don't have a good strategy for460 // mocking out the network. Maybe all network requests should go through a461 // "net" module?462 results.fetchBuildersWithCompileErrors = function(callback) {463 $.get('/buildbot', function(builderStatuses) {464 var brokenBuilders = [];465 466 $.each(builderStatuses, function(index, builderStatus) {467 if (builderStatus['is_green'])468 return;469 var builderName = builderStatus['name'];470 if (isBuilderThatOnlyCompiles(builderName))471 brokenBuilders.push(builderName);472 });473 474 callback(brokenBuilders);475 });476 };477 478 454 results.fetchResultsForBuilder = function(builderName, callback) 479 455 { -
trunk/Tools/ChangeLog
r92133 r92134 1 2011-08-01 Adam Barth <abarth@webkit.org> 2 3 garden-o-matic shouldn't require local server to determine if compile failed 4 https://bugs.webkit.org/show_bug.cgi?id=65446 5 6 Reviewed by Dimitri Glazkov. 7 8 This patch adds some basic bindings for the buildbot JSON API. I 9 wanted to use Buildbot.js an Builder.js from the original TestFailures, 10 but they make a number of WebKit-specific assumptions. We'll 11 eventually need to reconcile these pieces of code. 12 13 I should really add tests for this code, but that will require me to 14 build a better mock network. I'll be happy to do that in a follow-up 15 patch. 16 17 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added. 18 - It's very unclear to me whether didFail is correct. Supposedly 19 the first entry here is the exit code of the step, which is 0 on 20 success. I suspect we'll need to improve this function over time. 21 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: 22 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: 23 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: 24 1 25 2011-08-01 Adam Barth <abarth@webkit.org> 2 26
Note: See TracChangeset
for help on using the changeset viewer.