Changeset 92194 in webkit

Timestamp:

Aug 2, 2011 8:54:35 AM (13 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
​https://bugs.webkit.org/show_bug.cgi?id=65466

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/network-initiator-from-console.html

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):

LayoutTests:

• http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
• http/tests/inspector/network/network-initiator-from-console.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/inspector/network/network-initiator-from-console-expected.txt (added)
• LayoutTests/http/tests/inspector/network/network-initiator-from-console.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/inspector/front-end/NetworkPanel.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-01  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
+        https://bugs.webkit.org/show_bug.cgi?id=65466
+
+        Reviewed by Pavel Feldman.
+
+        * http/tests/inspector/network/network-initiator-from-console-expected.txt: Added.
+        * http/tests/inspector/network/network-initiator-from-console.html: Added.
+
 2011-08-02  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-01  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: [REGRESSION] Console evaluations leading to resource loading cause errors.
+        https://bugs.webkit.org/show_bug.cgi?id=65466
+
+        Reviewed by Pavel Feldman.
+
+        Test: http/tests/inspector/network/network-initiator-from-console.html
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
+
 2011-08-02  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -1948 +1948 @@
             if (initiator.type === "script") {
                 var topFrame = initiator.stackTrace[0];
+                // This could happen when resource loading was triggered by console. 
+                if (!topFrame.url) {
+                    this._initiatorCell.addStyleClass("network-dim-cell");
+                    this._initiatorCell.setTextAndTitle(WebInspector.UIString("Other"));
+                    return;
+                }
                 this._initiatorCell.title = topFrame.url + ":" + topFrame.lineNumber;
                 this._initiatorCell.appendChild(WebInspector.linkifyResourceAsNode(topFrame.url, "scripts", topFrame.lineNumber));