Changeset 92261 in webkit


Ignore:
Timestamp:
Aug 2, 2011 10:07:51 PM (13 years ago)
Author:
psolanki@apple.com
Message:

Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
https://bugs.webkit.org/show_bug.cgi?id=65584

Reviewed by David Kilzer.

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r92260 r92261  
     12011-08-02  Pratik Solanki  <psolanki@apple.com>
     2
     3        Crash in ResourceResponse::platformCompare() with USE(CFNETWORK)
     4        https://bugs.webkit.org/show_bug.cgi?id=65584
     5
     6        Reviewed by David Kilzer.
     7
     8        * platform/network/cf/ResourceResponseCFNet.cpp:
     9        (WebCore::ResourceResponse::platformCompare): Don't call CFEqual with 0 as an argument.
     10
    1112011-08-02  Takashi Toyoshima  <toyoshim@chromium.org>
    212
  • trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp

    r91102 r92261  
    138138bool ResourceResponse::platformCompare(const ResourceResponse& a, const ResourceResponse& b)
    139139{
     140    // CFEqual crashes if you pass it 0 so do an early check before calling it.
     141    if (!a.cfURLResponse() || !b.cfURLResponse())
     142        return a.cfURLResponse() == b.cfURLResponse();
    140143    return CFEqual(a.cfURLResponse(), b.cfURLResponse());
    141144}
Note: See TracChangeset for help on using the changeset viewer.