Changeset 92382 in webkit

Timestamp:

Aug 4, 2011 9:51:48 AM (13 years ago)

Author:

abarth@webkit.org

Message:

builders.js needs unit tests
​https://bugs.webkit.org/show_bug.cgi?id=65670

Reviewed by Dimitri Glazkov.

This test requires somewhat large test fixtures, but using real
examples seemed better than trimming them down too much.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  • Note: trac_unittests.js doesn't exist (yet!).

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js (modified) (3 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js (added)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js

@@ -62 +62 @@
 }
 
+function mostRecentCompletedBuildNumber(individualBuilderStatus)
+{
+    if (!individualBuilderStatus)
+        return null;
+
+    for (var i = individualBuilderStatus.cachedBuilds.length - 1; i >= 0; --i) {
+        var buildNumber = individualBuilderStatus.cachedBuilds[i];
+        if (individualBuilderStatus.currentBuilds.indexOf(buildNumber) == -1)
+            return buildNumber;
+    }
+
+    return null;
+}
+
 var g_buildInfoCache = new base.AsynchronousCache(function(key, callback) {
     var explodedKey = key.split('\n');
@@ -73 +87 @@
     net.get(kChromiumBuildBotURL + '/json/builders', function(builderStatus) {
         $.each(config.kBuilders, function(index, builderName) {
-            var buildNumber = builderStatus[builderName].cachedBuilds.pop();
+            var buildNumber = mostRecentCompletedBuildNumber(builderStatus[builderName]);
+            if (!buildNumber) {
+                buildInfoByBuilder[builderName] = null;
+                requestTracker.requestComplete();
+                return;
+            }
 
             g_buildInfoCache.get(builderName + '\n' + buildNumber, function(buildInfo) {
@@ -88 +107 @@
         var builderNameList = [];
         $.each(buildInfoByBuilder, function(builderName, buildInfo) {
+            if (!buildInfo)
+                return;
             if (didFailStepRequredForTestCoverage(buildInfo))
                 builderNameList.push(builderName);

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html

@@ -43 +43 @@
 <script src="net_unittests.js"></script>
 <script src="Trac.js"></script>
-<script src="trac_unittests.js"></script>
 <script src="Bugzilla.js"></script>
 <script src="bugzilla_unittests.js"></script>
+<script src="builders.js"></script>
+<script src="builders_unittests.js"></script>
 <script src="checkout.js"></script>
 <script src="checkout_unittests.js"></script>

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-04  Adam Barth  <abarth@webkit.org>
+
+        builders.js needs unit tests
+        https://bugs.webkit.org/show_bug.cgi?id=65670
+
+        Reviewed by Dimitri Glazkov.
+
+        This test requires somewhat large test fixtures, but using real
+        examples seemed better than trimming them down too much.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
+            - Note: trac_unittests.js doesn't exist (yet!).
+
 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>