Changeset 92530 in webkit

Timestamp:

Aug 5, 2011 5:24:50 PM (13 years ago)

Author:

Joseph Pecoraro

Message:

Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
​https://bugs.webkit.org/show_bug.cgi?id=65789

Reviewed by David Kilzer.

Fix a leak by adopting an allocation instead of retaining it.

• platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::httpBodyFromRequest):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/cf/FormDataStreamCFNet.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-05  Joseph Pecoraro  <joepeck@webkit.org>
+
+        Leak in CFNetwork Loader RetainPtr<> should Adopt a Copy allocation
+        https://bugs.webkit.org/show_bug.cgi?id=65789
+
+        Reviewed by David Kilzer.
+
+        Fix a leak by adopting an allocation instead of retaining it.
+
+        * platform/network/cf/FormDataStreamCFNet.cpp:
+        (WebCore::httpBodyFromRequest):
+
 2011-08-05  Ben Wells  <benwells@chromium.org>
 

trunk/Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp

@@ -92 +92 @@
 PassRefPtr<FormData> httpBodyFromRequest(CFURLRequestRef request)
 {
-    if (RetainPtr<CFDataRef> bodyData = CFURLRequestCopyHTTPRequestBody(request))
+    RetainPtr<CFDataRef> bodyData(AdoptCF, CFURLRequestCopyHTTPRequestBody(request));
+    if (bodyData)
         return FormData::create(CFDataGetBytePtr(bodyData.get()), CFDataGetLength(bodyData.get()));
 
-    if (RetainPtr<CFArrayRef> bodyParts = wkCFURLRequestCopyHTTPRequestBodyParts(request)) {
+    RetainPtr<CFArrayRef> bodyParts(AdoptCF, wkCFURLRequestCopyHTTPRequestBodyParts(request));
+    if (bodyParts) {
         RefPtr<FormData> formData = FormData::create();