Changeset 92576 in webkit


Ignore:
Timestamp:
Aug 7, 2011 7:06:58 PM (13 years ago)
Author:
koz@chromium.org
Message:

Make the fullscreen JS API enabled at runtime.
​https://bugs.webkit.org/show_bug.cgi?id=65501

Reviewed by Adam Barth.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):

  • dom/Document.idl:
  • dom/Element.idl:

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFullScreenAPI):
(WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):

Location:
trunk/Source
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r92573 r92576  
     12011-08-07  James Kozianski  <koz@chromium.org>
     2
     3        Make the fullscreen JS API enabled at runtime.
     4        https://bugs.webkit.org/show_bug.cgi?id=65501
     5
     6        Reviewed by Adam Barth.
     7
     8        * bindings/generic/RuntimeEnabledFeatures.cpp:
     9        * bindings/generic/RuntimeEnabledFeatures.h:
     10        (WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
     11        (WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
     12        (WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
     13        (WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
     14        (WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
     15        (WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
     16        (WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):
     17        * dom/Document.idl:
     18        * dom/Element.idl:
     19
    1202011-08-07  Martin Robinson  <mrobinson@igalia.com>
    221

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r89452 r92576  
    147147#endif
    148148
     149#if ENABLE(FULLSCREEN_API)
     150bool RuntimeEnabledFeatures::isFullScreenAPIEnabled = true;
     151#endif
     152
    149153} // namespace WebCore

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r92304 r92576  
    7171    static bool webkitIDBTransactionEnabled() { return isIndexedDBEnabled; }
    7272
     73#if ENABLE(FULLSCREEN_API)
     74    static bool webkitFullScreenAPIEnabled() { return isFullScreenAPIEnabled; }
     75    static void setWebkitFullScreenAPIEnabled(bool isEnabled) { isFullScreenAPIEnabled = isEnabled; }
     76    static bool webkitRequestFullScreenEnabled() { return isFullScreenAPIEnabled; }
     77    static bool webkitIsFullScreenEnabled() { return isFullScreenAPIEnabled; }
     78    static bool webkitFullScreenKeyboardInputAllowedEnabled() { return isFullScreenAPIEnabled; }
     79    static bool webkitCurrentFullScreenElementEnabled() { return isFullScreenAPIEnabled; }
     80    static bool webkitCancelFullScreenEnabled() { return isFullScreenAPIEnabled; }
     81#endif
     82
    7383#if ENABLE(VIDEO)
    7484    static bool audioEnabled();
    … …  
    193203    static bool isQuotaEnabled;
    194204#endif
     205
     206#if ENABLE(FULLSCREEN_API)
     207    static bool isFullScreenAPIEnabled;
     208#endif
    195209};
    196210

  • trunk/Source/WebCore/dom/Document.idl

    r92436 r92576  
    239239
    240240#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
    241         readonly attribute boolean webkitIsFullScreen;
    242         readonly attribute boolean webkitFullScreenKeyboardInputAllowed;
    243         readonly attribute Element webkitCurrentFullScreenElement;
    244         void webkitCancelFullScreen();
     241        readonly attribute [EnabledAtRuntime] boolean webkitIsFullScreen;
     242        readonly attribute [EnabledAtRuntime] boolean webkitFullScreenKeyboardInputAllowed;
     243        readonly attribute [EnabledAtRuntime] Element webkitCurrentFullScreenElement;
     244        [EnabledAtRuntime] void webkitCancelFullScreen();
    245245#endif
    246246

  • trunk/Source/WebCore/dom/Element.idl

    r92433 r92576  
    137137#if defined(ENABLE_FULLSCREEN_API) && ENABLE_FULLSCREEN_API
    138138        const unsigned short ALLOW_KEYBOARD_INPUT = 1;
    139         void webkitRequestFullScreen(in [Optional=CallWithDefaultValue] unsigned short flags);
     139        [EnabledAtRuntime] void webkitRequestFullScreen(in [Optional=CallWithDefaultValue] unsigned short flags);
    140140#endif
    141141

  • trunk/Source/WebKit/chromium/ChangeLog

    r92520 r92576  
     12011-08-07  James Kozianski  <koz@chromium.org>
     2
     3        Make the fullscreen JS API enabled at runtime.
     4        https://bugs.webkit.org/show_bug.cgi?id=65501
     5
     6        Reviewed by Adam Barth.
     7
     8        * public/WebRuntimeFeatures.h:
     9        * src/WebRuntimeFeatures.cpp:
     10        (WebKit::WebRuntimeFeatures::enableFullScreenAPI):
     11        (WebKit::WebRuntimeFeatures::isFullScreenAPIEnabled):
     12
    1132011-08-05  James Robinson  <jamesr@chromium.org>
    214

  • trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h

    r92322 r92576  
    107107    WEBKIT_EXPORT static bool isMediaStreamEnabled();
    108108
     109    WEBKIT_EXPORT static void enableFullScreenAPI(bool);
     110    WEBKIT_EXPORT static bool isFullScreenAPIEnabled();
     111
    109112private:
    110113    WebRuntimeFeatures();

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r89452 r92576  
    357357}
    358358
     359void WebRuntimeFeatures::enableFullScreenAPI(bool enable)
     360{
     361#if ENABLE(FULLSCREEN_API)
     362    RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled(enable);
     363#else
     364    UNUSED_PARAM(enable);
     365#endif
     366}
     367
     368bool WebRuntimeFeatures::isFullScreenAPIEnabled()
     369{
     370#if ENABLE(FULLSCREEN_API)
     371    return RuntimeEnabledFeatures::webkitFullScreenAPIEnabled();
     372#else
     373    return false;
     374#endif
     375}
     376
    359377} // namespace WebKit
Note: See TracChangeset for help on using the changeset viewer.