Changeset 92588 in webkit

Timestamp:

Aug 8, 2011 1:42:14 AM (13 years ago)

Author:

bashi@chromium.org

Message:

Should not use C-style cast in CSSParser.cpp
​https://bugs.webkit.org/show_bug.cgi?id=65807

Remove C-style cast.

Reviewed by Kent Tamura.

No new tests because no behavior change.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction): Replaced a cast with clampToInteger().
(WebCore::CSSParser::parseFontFeatureTag): Ditto.
(WebCore::CSSParser::createKeyframeRule): Replaced a cast with C++-style cast.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSParser.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-08  Kenichi Ishibashi  <bashi@chromium.org>
+
+        Should not use C-style cast in CSSParser.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=65807
+
+        Remove C-style cast.
+
+        Reviewed by Kent Tamura.
+
+        No new tests because no behavior change.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseAnimationTimingFunction): Replaced a cast with clampToInteger().
+        (WebCore::CSSParser::parseFontFeatureTag): Ditto.
+        (WebCore::CSSParser::createKeyframeRule): Replaced a cast with C++-style cast.
+
 2011-08-05  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/Source/WebCore/css/CSSParser.cpp

@@ -3285 +3285 @@
         if (!validUnit(v, FInteger, m_strict))
             return 0;
-        numSteps = static_cast<int>(min(v->fValue, (double)INT_MAX));
+        numSteps = clampToInteger(v->fValue);
         if (numSteps < 1)
             return 0;
@@ -6334 +6334 @@
     if (value) {
         if (value->unit == CSSPrimitiveValue::CSS_NUMBER && value->isInt && value->fValue >= 0) {
-            tagValue = static_cast<int>(value->fValue);
+            tagValue = clampToInteger(value->fValue);
             if (tagValue < 0)
                 return false;
@@ -6953 +6953 @@
     String keyString;
     for (unsigned i = 0; i < keys->size(); ++i) {
-        float key = (float) keys->valueAt(i)->fValue;
+        float key = static_cast<float>(keys->valueAt(i)->fValue);
         if (i != 0)
             keyString += ",";