Changeset 92637 in webkit

Timestamp:

Aug 8, 2011 2:37:55 PM (13 years ago)

Author:

abarth@webkit.org

Message:

Deprecate rebaseline-chromium-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=65873

Reviewed by Dimitri Glazkov.

This script never worked correctly and now is redundant with more
modern infrastructure for rebaselining tests. This patch deprecates
the script in order to flush out any issues with the new tools. Once
folks are happy with the new tools, we'll delete this script.

• Scripts/rebaseline-chromium-webkit-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/rebaseline-chromium-webkit-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-08  Adam Barth  <abarth@webkit.org>
+
+        Deprecate rebaseline-chromium-webkit-tests
+        https://bugs.webkit.org/show_bug.cgi?id=65873
+
+        Reviewed by Dimitri Glazkov.
+
+        This script never worked correctly and now is redundant with more
+        modern infrastructure for rebaselining tests.  This patch deprecates
+        the script in order to flush out any issues with the new tools.  Once
+        folks are happy with the new tools, we'll delete this script.
+
+        * Scripts/rebaseline-chromium-webkit-tests:
+
 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
 

trunk/Tools/Scripts/rebaseline-chromium-webkit-tests

@@ -32 +32 @@
 import webkitpy.to_be_moved.rebaseline_chromium_webkit_tests
 
+
 if __name__ == '__main__':
-    # FIXME: We shouldn't pass sys.argv to rebaseline_chromium_webkit_tests.
-    sys.exit(webkitpy.to_be_moved.rebaseline_chromium_webkit_tests.main(sys.argv[1:]))
+    print """This script is depreciated.  Please use use "webkit-patch rebaseline-expectations" instead.
+
+If that command does not work properly, please file a bug and CC abarth. If you
+really need to use the old script, run this command again with
+--use-deprecated-script as the first argument."""
+
+    if len(sys.argv) > 1 and sys.argv[1] == '--use-deprecated-script':
+        sys.exit(webkitpy.to_be_moved.rebaseline_chromium_webkit_tests.main(sys.argv[2:]))