Changeset 92641 in webkit

Timestamp:

Aug 8, 2011 3:04:34 PM (13 years ago)

Author:

abarth@webkit.org

Message:

bulk-optimize-baselines should take directories on the command line
​https://bugs.webkit.org/show_bug.cgi?id=65879

Reviewed by Dimitri Glazkov.

Passing lists of tests via stdin is a pain. It's easier if the command
takes a list of tests on the command line, like run-webkit-tests.

• Scripts/webkitpy/tool/commands/rebaseline.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/rebaseline.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-08  Adam Barth  <abarth@webkit.org>
+
+        bulk-optimize-baselines should take directories on the command line
+        https://bugs.webkit.org/show_bug.cgi?id=65879
+
+        Reviewed by Dimitri Glazkov.
+
+        Passing lists of tests via stdin is a pain.  It's easier if the command
+        takes a list of tests on the command line, like run-webkit-tests.
+
+        * Scripts/webkitpy/tool/commands/rebaseline.py:
+
 2011-08-08  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

@@ -31 +31 @@
 import shutil
 import urllib
-import fileinput
 
 import webkitpy.common.config.urls as config_urls
@@ -43 +42 @@
 from webkitpy.layout_tests.models.test_expectations import TestExpectations
 from webkitpy.layout_tests.port import factory, builders
+from webkitpy.layout_tests.port import test_files
 from webkitpy.tool.grammar import pluralize
 from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
@@ -121 +121 @@
 class BulkOptimizeBaselines(OptimizeBaselines):
     name = "bulk-optimize-baselines"
-    help_text = """Reshuffles the baselines for tests to use as litte space on disk as possible.
-Please provide the list of tests (separated by new lines) via stdin."""
-    argument_names = None
+    help_text = """Reshuffles the baselines for tests to use as litte space on disk as possible."""
+    argument_names = "TEST_NAMES"
+
+    def _to_test_name(self, file_name):
+        return self._tool.filesystem.relpath(file_name, self._port.layout_tests_dir())
 
     def execute(self, options, args, tool):
         self._baseline_optimizer = BaselineOptimizer(tool.scm(), tool.filesystem)
-        for test_name in fileinput.input(['-']):
-            test_name = test_name.strip()
+        self._port = factory.get("chromium-win-win7")  # FIXME: This should be selectable.
+
+        for test_name in map(self._to_test_name, test_files.find(self._port, args)):
             print "Optimizing %s." % test_name
             self._optimize_baseline(test_name)