Changeset 92883 in webkit

Timestamp:

Aug 11, 2011 3:02:33 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

The PageSerializer should always use absolute URL
​https://bugs.webkit.org/show_bug.cgi?id=66006

Patch by Benjamin Poulain <​benjamin@webkit.org> on 2011-08-11
Reviewed by Adam Barth.

Page serializer resolves every URL for storing the resources.
The MarkupAccumulator used there should use the same rules in order to
create a valid file.

No new tests because the test infrastructure for this
does not exist with layout tests and the Chromium unit test for
the serializer are disabled.

• page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/PageSerializer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-11  Benjamin Poulain  <benjamin@webkit.org>
+
+        The PageSerializer should always use absolute URL
+        https://bugs.webkit.org/show_bug.cgi?id=66006
+
+        Reviewed by Adam Barth.
+
+        Page serializer resolves every URL for storing the resources.
+        The MarkupAccumulator used there should use the same rules in order to
+        create a valid file.
+
+        No new tests because the test infrastructure for this
+        does not exist with layout tests and the Chromium unit test for
+        the serializer are disabled.
+
+        * page/PageSerializer.cpp:
+        (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):
+
 2011-08-01  Adrienne Walker  <enne@google.com>
 

trunk/Source/WebCore/page/PageSerializer.cpp

@@ -107 +107 @@
 };
 
-// FIXME: should that really use ResolveNonLocalURLs?
 SerializerMarkupAccumulator::SerializerMarkupAccumulator(PageSerializer* serializer, Document* document, Vector<Node*>* nodes)
-    : MarkupAccumulator(nodes, ResolveNonLocalURLs)
+    : MarkupAccumulator(nodes, ResolveAllURLs)
     , m_serializer(serializer)
     , m_document(document)