Changeset 93256 in webkit


Ignore:
Timestamp:
Aug 17, 2011 4:08:10 PM (13 years ago)
Author:
Dimitri Glazkov
Message:

Remove base.keys and replace it with Object.keys.
​https://bugs.webkit.org/show_bug.cgi?id=66422

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
Location:
trunk/Tools
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js

    r93163 r93256  
    7676};
    7777
    78 base.keys = function(dictionary)
    79 {
    80     var keys = [];
    81     $.each(dictionary, function(key, value) {
    82         keys.push(key);
    83     });
    84     return keys;
    85 };
    86 
    8778base.filterTree = function(tree, isLeaf, predicate)
    8879{

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js

    r93252 r93256  
    6767});
    6868
    69 test("keys", 4, function() {
    70     deepEqual(base.keys({}), []);
    71     deepEqual(base.keys({"a": 1}), ["a"]);
    72     deepEqual(base.keys({"a": 1, "b": 0}), ["a", "b"]);
    73     deepEqual(base.keys({"a": 1, "b": { "c" : 1}}), ["a", "b"]);
    74 });
    75 
    7669test("callInParallel", 4, function() {
    7770    var expectedCall = [true, true, true];

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js

    r93063 r93256  
    149149    var tracker = new base.RequestTracker(Object.keys(unexpectedFailures).length, completionCallback);
    150150    $.each(unexpectedFailures, function(testName, resultNodesByBuilder) {
    151         var builderNameList = base.keys(resultNodesByBuilder);
     151        var builderNameList = Object.keys(resultNodesByBuilder);
    152152        results.unifyRegressionRanges(builderNameList, testName, function(oldestFailingRevision, newestPassingRevision) {
    153153            var failureAnalysis = {

  • trunk/Tools/ChangeLog

    r93254 r93256  
     12011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
     2
     3        Remove base.keys and replace it with Object.keys.
     4        https://bugs.webkit.org/show_bug.cgi?id=66422
     5
     6        Reviewed by Adam Barth.
     7
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
     11
    1122011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
    213
Note: See TracChangeset for help on using the changeset viewer.