Changeset 93295 in webkit

Timestamp:

Aug 18, 2011 4:05:53 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
​https://bugs.webkit.org/show_bug.cgi?id=66282

Patch by Jing Zhao <​jingzhao@chromium.org> on 2011-08-18
Reviewed by Kent Tamura.

No new tests since it only changes the behavior in Android Browser.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseMappedAttribute):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLSelectElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-18  Jing Zhao  <jingzhao@chromium.org>
+
+        When changing the size of a menulist from x (x>1) to 1, the first item should be selected.
+        https://bugs.webkit.org/show_bug.cgi?id=66282
+
+        Reviewed by Kent Tamura.
+
+        No new tests since it only changes the behavior in Android Browser.
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::parseMappedAttribute):
+
 2011-08-18  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/html/HTMLSelectElement.cpp

@@ -245 +245 @@
 }
 
-void HTMLSelectElement::parseMappedAttribute(Attribute* attr) 
-{
-    bool oldUsesMenuList = m_data.usesMenuList();
+void HTMLSelectElement::parseMappedAttribute(Attribute* attr)
+{
     if (attr->name() == sizeAttr) {
         int oldSize = m_data.size();
@@ -264 +263 @@
         m_data.setSize(size);
         setNeedsValidityCheck();
-        if ((oldUsesMenuList != m_data.usesMenuList() || (!oldUsesMenuList && m_data.size() != oldSize)) && attached()) {
+        if (m_data.size() != oldSize && attached()) {
             reattach();
             setRecalcListItems();