Changeset 93311 in webkit

Timestamp:

Aug 18, 2011 8:51:27 AM (13 years ago)

Author:

caio.oliveira@openbossa.org

Message:

[GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
​https://bugs.webkit.org/show_bug.cgi?id=66243

Reviewed by Martin Robinson.

The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
call it only when the "load-status" change.

This change is important in the context of bug 28851, which aims to change the
order in which "progress finished" and "load finished" callbacks are called. In
this new scenario, at the progress callback the load will never be finished.

• tests/testwebview.c:

(test_webkit_web_view_grab_focus):

Location:

trunk/Source/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• tests/testwebview.c (modified) (2 diffs)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-08-18  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
+
+        [GTK] Change webview API tests to use "load-status" signal instead of "load-progress"
+        https://bugs.webkit.org/show_bug.cgi?id=66243
+
+        Reviewed by Martin Robinson.
+
+        The idle_quit_loop_cb() already checks the "load-status" flag, so it is enough to
+        call it only when the "load-status" change.
+
+        This change is important in the context of bug 28851, which aims to change the
+        order in which "progress finished" and "load finished" callbacks are called. In
+        this new scenario, at the progress callback the load will never be finished.
+
+        * tests/testwebview.c:
+        (test_webkit_web_view_grab_focus):
+
 2011-08-17  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebKit/gtk/tests/testwebview.c

@@ -168 +168 @@
     loop = g_main_loop_new(NULL, TRUE);
 
-    g_signal_connect(view, "notify::progress", G_CALLBACK (idle_quit_loop_cb), NULL);
+    g_signal_connect(view, "notify::load-status", G_CALLBACK(idle_quit_loop_cb), NULL);
 
     /* Wait for window to show up */
@@ -236 +236 @@
 
     g_object_connect(G_OBJECT(view),
-                     "signal::notify::progress", idle_quit_loop_cb, NULL,
+                     "signal::notify::load-status", idle_quit_loop_cb, NULL,
                      NULL);