Changeset 93503 in webkit


Ignore:
Timestamp:
Aug 22, 2011 4:53:19 AM (13 years ago)
Author:
keishi@webkit.org
Message:

Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
https://bugs.webkit.org/show_bug.cgi?id=66658

Reviewed by Kent Tamura.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.

  • html/ColorInputType.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r93501 r93503  
     12011-08-22  Keishi Hattori  <keishi@webkit.org>
     2
     3        Chrome::setSelectedColorInColorChooser shouldn't be called when color chooser sets a new color
     4        https://bugs.webkit.org/show_bug.cgi?id=66658
     5
     6        Reviewed by Kent Tamura.
     7
     8        * html/ColorInputType.cpp:
     9        (WebCore::ColorInputType::colorSelected): Call setValueFromRenderer instead of setValue.
     10        * html/ColorInputType.h:
     11
    1122011-08-18  Pavel Podivilov  <podivilov@chromium.org>
    213
  • trunk/Source/WebCore/html/ColorInputType.cpp

    r92592 r93503  
    106106}
    107107
    108 void ColorInputType::setValueAsColor(const Color& color) const
    109 {
    110     element()->setValue(color.serialized(), true);
    111 }
    112 
    113108void ColorInputType::createShadowSubtree()
    114109{
     
    175170    if (element()->disabled() || element()->readOnly())
    176171        return;
    177     setValueAsColor(color);
     172    element()->setValueFromRenderer(color.serialized());
     173    updateColorSwatch();
    178174}
    179175
  • trunk/Source/WebCore/html/ColorInputType.h

    r92592 r93503  
    5454    virtual String sanitizeValue(const String&);
    5555    virtual Color valueAsColor() const;
    56     virtual void setValueAsColor(const Color&) const;
    5756    virtual void createShadowSubtree();
    5857    virtual void valueChanged();
Note: See TracChangeset for help on using the changeset viewer.