Changeset 93510 in webkit


Ignore:
Timestamp:
Aug 22, 2011 8:36:28 AM (13 years ago)
Author:
loislo@chromium.org
Message:

Web Inspector: bind registerDomainDispatcher to domain names.
https://bugs.webkit.org/show_bug.cgi?id=66670

jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
I'd like to introduce named versions per each domain.

Reviewed by Pavel Feldman.

  • inspector/CodeGeneratorInspector.pm:

(GenerateInterface):
(generateBackendStubJS):

  • inspector/front-end/ApplicationCacheItemsView.js:
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent):

  • inspector/front-end/DOMStorage.js:
  • inspector/front-end/Database.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel):

  • inspector/front-end/NetworkManager.js:

(WebInspector.NetworkDispatcher):

  • inspector/front-end/ProfilesPanel.js:
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):

  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineDispatcher):

  • inspector/front-end/WorkerManager.js:

(WebInspector.WorkerManager):

  • inspector/front-end/inspector.js:
Location:
trunk/Source/WebCore
Files:
14 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r93507 r93510  
     12011-08-22  Ilya Tikhonovsky  <loislo@chromium.org>
     2
     3        Web Inspector: bind registerDomainDispatcher to domain names.
     4        https://bugs.webkit.org/show_bug.cgi?id=66670
     5
     6        jscompiler can't be used for validating domain events dispatchers because registerDomainDispatcher is too generic.
     7        I'd like to introduce named versions per each domain.
     8
     9        Reviewed by Pavel Feldman.
     10
     11        * inspector/CodeGeneratorInspector.pm:
     12        (GenerateInterface):
     13        (generateBackendStubJS):
     14        * inspector/front-end/ApplicationCacheItemsView.js:
     15        * inspector/front-end/ConsoleView.js:
     16        * inspector/front-end/DOMAgent.js:
     17        (WebInspector.DOMAgent):
     18        * inspector/front-end/DOMStorage.js:
     19        * inspector/front-end/Database.js:
     20        * inspector/front-end/DebuggerModel.js:
     21        (WebInspector.DebuggerModel):
     22        * inspector/front-end/NetworkManager.js:
     23        (WebInspector.NetworkDispatcher):
     24        * inspector/front-end/ProfilesPanel.js:
     25        * inspector/front-end/ResourceTreeModel.js:
     26        (WebInspector.ResourceTreeModel):
     27        * inspector/front-end/TimelineManager.js:
     28        (WebInspector.TimelineDispatcher):
     29        * inspector/front-end/WorkerManager.js:
     30        (WebInspector.WorkerManager):
     31        * inspector/front-end/inspector.js:
     32
    1332011-08-22  Benjamin Poulain  <benjamin@webkit.org>
    234
  • trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm

    r93389 r93510  
    246246my @frontendConstantDefinitions;
    247247my @frontendFooter;
     248my @frontendDomains;
    248249
    249250# Default constructor
     
    305306    generateFunctions($interface, \%agent);
    306307    if (@{$agent{methodDeclarations}}) {
     308        push(@frontendDomains, $interface->name);
    307309        generateAgentDeclaration($interface, \%agent);
    308310    }
     
    756758sub generateBackendStubJS
    757759{
     760    my $JSRegisterDomainDispatchers = join("\n", map("    this.register" . $_ . "Dispatcher = this._registerDomainDispatcher.bind(this, \"" . $_ ."\");", @frontendDomains));
    758761    my $JSStubs = join("\n", @backendJSStubs);
    759762    my $JSEvents = join("\n", @backendJSEvents);
     
    770773$JSStubs
    771774$JSEvents
     775$JSRegisterDomainDispatchers
    772776}
    773777
     
    855859    },
    856860
    857     registerDomainDispatcher: function(domain, dispatcher)
     861    _registerDomainDispatcher: function(domain, dispatcher)
    858862    {
    859863        this._domainDispatchers[domain] = dispatcher;
  • trunk/Source/WebCore/inspector/front-end/ApplicationCacheItemsView.js

    r93196 r93510  
    309309}
    310310
    311 InspectorBackend.registerDomainDispatcher("ApplicationCache", new WebInspector.ApplicationCacheDispatcher());
     311InspectorBackend.registerApplicationCacheDispatcher(new WebInspector.ApplicationCacheDispatcher());
  • trunk/Source/WebCore/inspector/front-end/ConsoleView.js

    r93196 r93510  
    158158            },
    159159        }
    160         InspectorBackend.registerDomainDispatcher("Console", dispatcher);
     160        InspectorBackend.registerConsoleDispatcher(dispatcher);
    161161    },
    162162
  • trunk/Source/WebCore/inspector/front-end/DOMAgent.js

    r93398 r93510  
    337337    this._document = null;
    338338    this._attributeLoadNodeIds = {};
    339     InspectorBackend.registerDomainDispatcher("DOM", new WebInspector.DOMDispatcher(this));
     339    InspectorBackend.registerDOMDispatcher(new WebInspector.DOMDispatcher(this));
    340340}
    341341
  • trunk/Source/WebCore/inspector/front-end/DOMStorage.js

    r84904 r93510  
    8787}
    8888
    89 InspectorBackend.registerDomainDispatcher("DOMStorage", new WebInspector.DOMStorageDispatcher());
     89InspectorBackend.registerDOMStorageDispatcher(new WebInspector.DOMStorageDispatcher());
  • trunk/Source/WebCore/inspector/front-end/Database.js

    r81674 r93510  
    144144}
    145145
    146 InspectorBackend.registerDomainDispatcher("Database", new WebInspector.DatabaseDispatcher());
     146InspectorBackend.registerDatabaseDispatcher(new WebInspector.DatabaseDispatcher());
  • trunk/Source/WebCore/inspector/front-end/DebuggerModel.js

    r93501 r93510  
    3434    this._scripts = {};
    3535
    36     InspectorBackend.registerDomainDispatcher("Debugger", new WebInspector.DebuggerDispatcher(this));
     36    InspectorBackend.registerDebuggerDispatcher(new WebInspector.DebuggerDispatcher(this));
    3737}
    3838
  • trunk/Source/WebCore/inspector/front-end/NetworkManager.js

    r92953 r93510  
    8282    this._inflightResourcesById = {};
    8383    this._inflightResourcesByURL = {};
    84     InspectorBackend.registerDomainDispatcher("Network", this);
     84    InspectorBackend.registerNetworkDispatcher(this);
    8585}
    8686
  • trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js

    r93196 r93510  
    130130        this._registerProfileType(new WebInspector.DetailedHeapshotProfileType());
    131131
    132     InspectorBackend.registerDomainDispatcher("Profiler", new WebInspector.ProfilerDispatcher(this));
     132    InspectorBackend.registerProfilerDispatcher(new WebInspector.ProfilerDispatcher(this));
    133133
    134134    if (Preferences.profilerAlwaysEnabled || WebInspector.settings.profilerEnabled.get())
  • trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js

    r92776 r93510  
    4040
    4141    this.frontendReused();
    42     InspectorBackend.registerDomainDispatcher("Page", new WebInspector.PageDispatcher(this));
     42    InspectorBackend.registerPageDispatcher(new WebInspector.PageDispatcher(this));
    4343   
    4444    this._pendingConsoleMessages = {};
  • trunk/Source/WebCore/inspector/front-end/TimelineManager.js

    r91565 r93510  
    6767{
    6868    this._manager = manager;
    69     InspectorBackend.registerDomainDispatcher("Timeline", this);
     69    InspectorBackend.registerTimelineDispatcher(this);
    7070}
    7171
  • trunk/Source/WebCore/inspector/front-end/WorkerManager.js

    r91454 r93510  
    3232{
    3333    this._workerIdToWindow = {};
    34     InspectorBackend.registerDomainDispatcher("Worker", new WebInspector.DedicatedWorkerMessageForwarder(this));
     34    InspectorBackend.registerWorkerDispatcher(new WebInspector.DedicatedWorkerMessageForwarder(this));
    3535}
    3636
  • trunk/Source/WebCore/inspector/front-end/inspector.js

    r93196 r93510  
    504504    new WebInspector.JavaScriptContextManager(this.resourceTreeModel, this.console);
    505505
    506     InspectorBackend.registerDomainDispatcher("Inspector", this);
     506    InspectorBackend.registerInspectorDispatcher(this);
    507507
    508508    this.resourceCategories = {
Note: See TracChangeset for help on using the changeset viewer.