Changeset 93522 in webkit

Timestamp:

Aug 22, 2011 11:15:48 AM (13 years ago)

Author:

Dimitri Glazkov

Message:

garden-o-matic's relative time display should be updated regularly.
​https://bugs.webkit.org/show_bug.cgi?id=66682

Reviewed by Adam Barth.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js (modified) (2 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js (modified) (5 diffs)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js

@@ -68 +68 @@
 var kTenMinutesInMilliseconds = 10 * 60 * 1000;
 config.kUpdateFrequency = kTenMinutesInMilliseconds;
+config.kRelativeTimeUpdateFrequency = 1000;
+
+
 
 })();

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

@@ -178 +178 @@
 };
 
+setInterval(function() {
+    Array.prototype.forEach.call(document.querySelectorAll("time.relative"), function(time) {
+        time.update && time.update();
+    });
+}, config.kRelativeTimeUpdateFrequency);
+
+ui.RelativeTime = base.extends('time', {
+    init: function()
+    {
+        this.setDate(new Date());
+        this.className = 'relative';
+    },
+    date: function()
+    {
+        return this._date;
+    },
+    update: function()
+    {
+        this.textContent = base.relativizeTime(this._date);
+    },
+    setDate: function(date)
+    {
+        this._date = date;
+        this.textContent = base.relativizeTime(date);
+    }
+});
+
 })();

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js

@@ -81 +81 @@
 });
 
-var Time = base.extends('time', {
-    init: function()
-    {
-        this.setDate(new Date());
-    },
-    date: function()
-    {
-        return this._date;
-    },
-    setDate: function(date)
-    {
-        this._date = date;
-        this.textContent = base.relativizeTime(date);
-    }
-});
-
 ui.notifications.FailingTest = base.extends('li', {
     init: function(failureAnalysis)
@@ -136 +120 @@
     init: function()
     {
-        this._time = this.insertBefore(new Time(), this.firstChild);
+        this._time = this.insertBefore(new ui.RelativeTime(), this.firstChild);
         this._problem = this._what.appendChild(document.createElement('div'));
         this._problem.className = 'problem';

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js

@@ -95 +95 @@
     equal(testFailures.tagName, 'LI');
     equal(testFailures.innerHTML,
-        '<time>Just now</time>' +
+        '<time class="relative">Just now</time>' +
         '<div class="what">' +
             '<div class="problem">' +
@@ -107 +107 @@
     testFailures.addFailureAnalysis({testName: 'test'});
     equal(testFailures.innerHTML,
-        '<time>Just now</time>' +
+        '<time class="relative">Just now</time>' +
         '<div class="what">' +
             '<div class="problem">' +
@@ -123 +123 @@
     testFailures.addFailureAnalysis({testName: 'test'});
     equal(testFailures.innerHTML,
-        '<time>Just now</time>' +
+        '<time class="relative">Just now</time>' +
         '<div class="what">' +
             '<div class="problem">' +
@@ -139 +139 @@
     testFailures.addCommitData({revision: 1, time: time, title: "title", author: "author", reviewer: "reviewer"});
     equal(testFailures.innerHTML,
-        '<time>10 minutes ago</time>' +
+        '<time class="relative">10 minutes ago</time>' +
         '<div class="what">' +
             '<div class="problem">' +
@@ -166 +166 @@
     builderFailing.setFailingBuilders(['WebKit Linux', 'Webkit Vista']);
     equal(builderFailing.innerHTML,
-        '<time>Just now</time>' +
+        '<time class="relative">Just now</time>' +
         '<div class="what">' +
             '<div class="problem">Build Failed:' +

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js

@@ -163 +163 @@
 });
 
+test("time", 6, function() {
+    var time = new ui.RelativeTime();
+    equal(time.tagName, 'TIME');
+    equal(time.className, 'relative');
+    deepEqual(Object.getOwnPropertyNames(time.__proto__), ['init', 'date', 'setDate', 'update']);
+    equal(time.outerHTML, '<time class="relative">Just now</time>');
+    var tenMinutesAgo = new Date();
+    tenMinutesAgo.setMinutes(tenMinutesAgo.getMinutes() - 10);
+    time.setDate(tenMinutesAgo);
+    equal(time.outerHTML, '<time class="relative">10 minutes ago</time>');
+    equal(time.date().getTime(), tenMinutesAgo.getTime());
+});
+
 })();

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        garden-o-matic's relative time display should be updated regularly.
+        https://bugs.webkit.org/show_bug.cgi?id=66682
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
+
 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>