Changeset 93652 in webkit


Ignore:
Timestamp:
Aug 23, 2011 4:12:27 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

[Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
​https://bugs.webkit.org/show_bug.cgi?id=66635

When mobile theme is in use and application palette is using light
color to display text button text becomes invisible. The reason for
that is that in RenderThemeQt::systemFont() we are using application
pallete while when are painting buttons lightGrayPalette is used.
Calling setPaletteFromPageClientIfExists() takes care of the issue.

Patch by Misha Tyutyunik <​michael.tyutyunik@nokia.com> on 2011-08-23
Reviewed by Andreas Kling.

Covered by existing tests.

  • platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::systemColor):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r93651 r93652  
     12011-08-23  Misha Tyutyunik  <michael.tyutyunik@nokia.com>
     2
     3        [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color.
     4        https://bugs.webkit.org/show_bug.cgi?id=66635
     5
     6        When mobile theme is in use and application palette is using light
     7        color to display text button text becomes invisible. The reason for
     8        that is that in RenderThemeQt::systemFont() we are using application
     9        pallete while when are painting buttons lightGrayPalette is used.
     10        Calling setPaletteFromPageClientIfExists() takes care of the issue.
     11       
     12        Reviewed by Andreas Kling.
     13
     14        Covered by existing tests.
     15
     16        * platform/qt/RenderThemeQt.cpp:
     17        (WebCore::RenderThemeQt::systemColor):
     18
    1192011-08-23  Tony Chang  <tony@chromium.org>
    220

  • trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp

    r93644 r93652  
    439439{
    440440    QPalette pal = QApplication::palette();
     441    setPaletteFromPageClientIfExists(pal);
    441442    switch (cssValueId) {
    442443    case CSSValueButtontext:
Note: See TracChangeset for help on using the changeset viewer.