Changeset 93721 in webkit

Timestamp:

Aug 24, 2011 12:53:32 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[CSSRegions] RenderRegion is not used if there's another renderer after it
​https://bugs.webkit.org/show_bug.cgi?id=66844

Source/WebCore:

There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
the region was not added to the RenderFlowThread.

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html

• rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

Patch by Alexandru Chiculita <Alexandru Chiculita> on 2011-08-24
Reviewed by David Hyatt.

• fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Added.
• fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
• fast/regions/content-flowed-into-regions-dynamically-inserted.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png (added)
• LayoutTests/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt (added)
• LayoutTests/fast/regions/content-flowed-into-regions-dynamically-inserted.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderObjectChildList.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-08-24  Alexandru Chiculita  <achicu@adobe.com>
+
+        [CSSRegions] RenderRegion is not used if there's another renderer after it
+        https://bugs.webkit.org/show_bug.cgi?id=66844
+
+        Reviewed by David Hyatt.
+
+        * fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Added.
+        * fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
+        * fast/regions/content-flowed-into-regions-dynamically-inserted.html: Added.
+
 2011-08-23  Peter Kasting  <pkasting@google.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-24  Alexandru Chiculita  <achicu@adobe.com>
+
+        [CSSRegions] RenderRegion is not used if there's another renderer after it
+        https://bugs.webkit.org/show_bug.cgi?id=66844
+
+        There was no call to attachRegion in RenderObjectChildList::insertChildNode, so
+        the region was not added to the RenderFlowThread.
+
+        Reviewed by David Hyatt.
+
+        Test: fast/regions/content-flowed-into-regions-dynamically-inserted.html
+
+        * rendering/RenderObjectChildList.cpp:
+        (WebCore::RenderObjectChildList::insertChildNode):
+
 2011-08-24  Sam Weinig  <sam@webkit.org>
 

trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

@@ -260 +260 @@
         if (!child->isFloating() && owner->childrenInline())
             owner->dirtyLinesFromChangedChild(child);
-        
+
+        if (child->isRenderRegion())
+            toRenderRegion(child)->attachRegion();
+
         if (RenderFlowThread* containerFlowThread = renderFlowThreadContainer(owner))
             containerFlowThread->addFlowChild(child, beforeChild);