Changeset 93738 in webkit


Ignore:
Timestamp:
Aug 24, 2011 2:33:38 PM (13 years ago)
Author:
abarth@webkit.org
Message:

Finish writing up details-view in garden-o-matic
​https://bugs.webkit.org/show_bug.cgi?id=66891

Reviewed by Dimitri Glazkov.

This patch mostly just copies a bunch of CSS from main.css to
summary.css. Presumably we'll delete main.css soon.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
Location:
trunk/Tools
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js

    r93607 r93738  
    110110
    111111        var testNameList = failures.testNameList();
    112         var failuresByTest = results.unexpectedFailuresByTest(model.state.resultsByBuilder)
    113         var controller = new controllers.ResultsDetails(resultsView, base.filterDictionary(failuresByTest, function(key) {
    114             return testNameList.indexOf(testNameList) != -1;
    115         }));
     112        var failuresByTest = base.filterDictionary(
     113            results.unexpectedFailuresByTest(model.state.resultsByBuilder),
     114            function(key) {
     115                return testNameList.indexOf(key) != -1;
     116            });
     117
     118        var controller = new controllers.ResultsDetails(resultsView, failuresByTest);
     119        controller.showTest(testNameList[0]);
    116120
    117121        // FIXME: This doesn't belong here. Also, we need some way to call controller.dismiss().

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js

    r93483 r93738  
    6666ui.actions.Next = base.extends(Action, {
    6767    init: function() {
    68         this.textContent = '▶';
     68        this.innerHTML = '▶';
    6969        this._eventName = 'next';
    7070        this.className = 'next';
    … …  
    7474ui.actions.Previous = base.extends(Action, {
    7575    init: function() {
    76         this.textContent = '◀';
     76        this.innerHTML = '◀';
    7777        this._eventName = 'previous';
    7878        this.className = 'previous';

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js

    r93483 r93738  
    7070    equal(list.innerHTML,
    7171        '<li><button>Rebaseline</button></li>' +
    72         '<li><button class="previous">&amp;#9664;</button></li>' +
    73         '<li><button class="next">&amp;#9654;</button></li>');
     72        '<li><button class="previous">◀</button></li>' +
     73        '<li><button class="next">▶</button></li>');
    7474});
    7575

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css

    r93152 r93738  
    2323 * THE POSSIBILITY OF SUCH DAMAGE.
    2424 */
     25
     26table {
     27    table-layout: fixed;
     28    width: 100%;
     29    border-collapse: collapse;
     30}
     31
     32td, th {
     33    overflow: hidden;
     34    vertical-align: top;
     35}
     36
     37button {
     38    border-radius: 2px;
     39    background-image: -webkit-linear-gradient(top,#f5f5f5,#f1f1f1);
     40    border: 1px solid rgba(0, 0, 0, 0.1);
     41    border-radius: 2px;
     42    color: #666;
     43    cursor: pointer;
     44    font-size: 11px;
     45    font-weight: bold;
     46    height: 29px;
     47    line-height: 27px;
     48    margin: 11px 6px;
     49    min-width: 54px;
     50    padding: 0 8px;
     51    text-align: center
     52}
     53
     54button.next {
     55    margin-left: 0px;
     56}
     57
     58button.previous {
     59    margin-right: 0px;
     60}
     61
     62button[disabled] {
     63    visibility: hidden;
     64}
     65
     66button:hover {
     67    background-image: -webkit-linear-gradient(top,#f8f8f8,#f1f1f1);
     68    -webkit-box-shadow: 0 1px 1px rgba(0,0,0,0.1);
     69    background-color: #f8f8f8;
     70    background-image: linear-gradient(top,#f8f8f8,#f1f1f1);
     71    border: 1px solid #c6c6c6;
     72    box-shadow: 0 1px 1px rgba(0,0,0,0.1);
     73    color: #333
     74}
     75
     76button:focus {
     77    border: 1px solid #4d90fe;
     78    outline: none
     79}
     80
     81button.default {
     82    border: 1px solid #3079ED;
     83    color: white;
     84    background-image: -webkit-linear-gradient(top,#4d90fe,#4787ed);
     85}
     86
     87button.default:hover {
     88    border: 1px solid #2f5bb7;
     89    color: white;
     90    background-color: #357ae8;
     91    background-image: -webkit-gradient(linear,left top,left bottom,from(#4d90fe),to(#357ae8));
     92}
     93
     94.clear {
     95    clear: both;
     96}
    2597
    2698ol.notifications {
    … …  
    67139    display: inline;
    68140}
     141
     142/*** results-view ***/
     143
     144.results-view {
     145    background-color: #f5f5f5;
     146}
     147
     148.results-view .toolbar {
     149    border-top: 1px solid #c6c6c6;
     150    border-bottom: 1px solid #c6c6c6;
     151}
     152
     153.results-view .toolbar .selector {
     154    font-size: 11px;
     155    font-weight: bold;
     156    height: 29px;
     157    line-height: 27px;
     158    margin: 11px 6px;
     159    padding: 0 8px;
     160}
     161
     162.results-view .test-selector {
     163    width: 400px;
     164    margin-right: 6px;
     165}
     166
     167.results-view .toolbar .actions {
     168    float: right;
     169}
     170
     171.results-view .toolbar ul.actions {
     172    margin: 0;
     173    padding: 0;
     174    list-style: none;
     175    display: inline-block;
     176}
     177
     178.results-view .toolbar ul.actions li {
     179    display: inline-block;
     180}
     181
     182.results-view td {
     183    background-color: white;
     184}
     185
     186.text-result {
     187    border: none;
     188    width: 100%;
     189    height: 400px; /* FIXME: How do we get a reasonable height here? */
     190}
     191
     192.image-result {
     193    width: 100%;
     194    height: auto;
     195}

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html

    r93607 r93738  
    3434<body>
    3535<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.6.2/jquery.min.js"></script>
     36<script src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.8.15/jquery-ui.min.js"></script>
    3637<script src="scripts/config.js"></script>
    3738<script src="scripts/base.js"></script>

  • trunk/Tools/ChangeLog

    r93737 r93738  
     12011-08-24  Adam Barth  <abarth@webkit.org>
     2
     3        Finish writing up details-view in garden-o-matic
     4        https://bugs.webkit.org/show_bug.cgi?id=66891
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        This patch mostly just copies a bunch of CSS from main.css to
     9        summary.css.  Presumably we'll delete main.css soon.
     10
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
     16
    1172011-08-24  James Robinson  <jamesr@chromium.org>
    218
Note: See TracChangeset for help on using the changeset viewer.