Changeset 93840 in webkit


Ignore:
Timestamp:
Aug 25, 2011 5:36:13 PM (13 years ago)
Author:
abarth@webkit.org
Message:

garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=66982

Reviewed by Dimitri Glazkov.

This patch just wires the rollout event through the controller to the
local server, which is already set up to perform rollouts.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js

    r93259 r93840  
    6464};
    6565
     66checkout.rollout = function(revision, reason, callback)
     67{
     68    net.post(config.kLocalServerURL + '/rollout?' + $.param({
     69        'revision': revision,
     70        'reason': reason
     71    }), function() {
     72        callback();
     73    });
     74};
     75
    6676checkout.rebaseline = function(failureInfoList, callback)
    6777{
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js

    r93830 r93840  
    9999            failure = new ui.notifications.TestFailures();
    100100            model.commitDataListForRevisionRange(impliedFirstFailingRevision, failureAnalysis.oldestFailingRevision).forEach(function(commitData) {
    101                 failure.addCommitData(commitData);
    102             });
     101                var suspiciousCommit = failure.addCommitData(commitData);
     102                $(suspiciousCommit).bind('rollout', function() {
     103                    this.onRollout(commitData.revision, failure.testNameList());
     104                }.bind(this));
     105            }, this);
    103106            this._view.add(failure);
    104107            $(failure).bind('examine', function() {
     
    133136        // FIXME: This doesn't belong here. Also, we need some way to call controller.dismiss().
    134137        document.body.appendChild(resultsView);
     138    },
     139    onRollout: function(revision, testNameList)
     140    {
     141        checkout.rollout(revision, ui.rolloutReasonForTestNameList(testNameList), $.noop);
    135142    }
    136143});
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js

    r93658 r93840  
    8383};
    8484
     85ui.rolloutReasonForTestNameList = function(testNameList)
     86{
     87    return 'Broke:\n' + testNameList.map(function(testName) {
     88        return '* ' + testName;
     89    }).join('\n');
     90}
     91
    8592function builderTableDataCells(resultNodesByBuilder)
    8693{
  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js

    r93522 r93840  
    5555            '<li><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Another+Builder">Another Builder</a></li>' +
    5656        '</ul></div>');
     57});
     58
     59test("rolloutReasonForTestNameList", 2, function() {
     60    equal(ui.rolloutReasonForTestNameList(["path/to/test.html"]), "Broke:\n* path/to/test.html");
     61    equal(ui.rolloutReasonForTestNameList(["path/to/test.html", "another/test.html"]), "Broke:\n* path/to/test.html\n* another/test.html");
    5762});
    5863
  • trunk/Tools/ChangeLog

    r93831 r93840  
     12011-08-25  Adam Barth  <abarth@webkit.org>
     2
     3        garden-o-matic should be able to roll out patches
     4        https://bugs.webkit.org/show_bug.cgi?id=66982
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        This patch just wires the rollout event through the controller to the
     9        local server, which is already set up to perform rollouts.
     10
     11        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
     15
    1162011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
    217
Note: See TracChangeset for help on using the changeset viewer.