Changeset 93915 in webkit

Timestamp:

Aug 26, 2011 2:46:00 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Update topCallFrame when calling host functions in the JIT
​https://bugs.webkit.org/show_bug.cgi?id=67010

Patch by Juan C. Montemayor <​jmont@apple.com> on 2011-08-26
Reviewed by Oliver Hunt.

The topCallFrame is not being updated when a host function is
called by the JIT. This causes problems when trying to create a
stack trace (​https://bugs.webkit.org/show_bug.cgi?id=66994).

• jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITOpcodes.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-08-26  Juan C. Montemayor  <jmont@apple.com>
+
+        Update topCallFrame when calling host functions in the JIT
+        https://bugs.webkit.org/show_bug.cgi?id=67010
+
+        Reviewed by Oliver Hunt.
+        
+        The topCallFrame is not being updated when a host function is
+        called by the JIT. This causes problems when trying to create a
+        stack trace (https://bugs.webkit.org/show_bug.cgi?id=66994).
+
+        * jit/JITOpcodes.cpp:
+        (JSC::JIT::privateCompileCTIMachineTrampolines):
+        (JSC::JIT::privateCompileCTINativeCall):
+
 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp

@@ -141 +141 @@
     storePtr(regT1, regT2);
     poke(callFrameRegister, 1 + OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof(void*));
+    storePtr(callFrameRegister, &m_globalData->topCallFrame);
     poke(TrustedImmPtr(FunctionPtr(ctiVMThrowTrampoline).value()));
     ret();
@@ -281 +282 @@
     poke(callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof(void*));
 
+    storePtr(callFrameRegister, &m_globalData->topCallFrame);
     // Set the return address.
     move(TrustedImmPtr(FunctionPtr(ctiVMThrowTrampoline).value()), regT1);