Changeset 93926 in webkit
- Timestamp:
- Aug 26, 2011 5:23:11 PM (13 years ago)
- Location:
- trunk/Tools
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js
r93906 r93926 110 110 { 111 111 var linkToRevision = this._description.appendChild(document.createElement('a')); 112 // FIXME: Set href.113 linkToRevision. href = '';112 linkToRevision.href = trac.changesetURL(commitData.revision); 113 linkToRevision.target = '_blank'; 114 114 linkToRevision.textContent = commitData.revision; 115 // FIXME: Reviewer could be unknown. 116 // FIXME: Provide opportunities to style title/author/reviewer separately. 117 this._description.appendChild(document.createTextNode(commitData.title + ' ' + commitData.author + ' (' + commitData.reviewer + ')')); 115 this._addDescriptionPart('title', commitData); 116 this._addDescriptionPart('author', commitData); 117 this._addDescriptionPart('reviewer', commitData); 118 }, 119 _addDescriptionPart: function(part, commitData) 120 { 121 var content = commitData[part]; 122 if (!content) 123 return; 124 125 var span = this._description.appendChild(document.createElement('span')); 126 span.className = part; 127 span.textContent = content; 118 128 } 119 129 }); -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js
r93906 r93926 88 88 var suspiciousCommit = new ui.notifications.SuspiciousCommit({revision: 1, title: "title", author: "author", reviewer: "reviewer"}); 89 89 equal(suspiciousCommit.tagName, 'LI'); 90 equal(suspiciousCommit.innerHTML, '<div class="description"><a href="">1</a>title author (reviewer)</div><ul class="actions"><li><button>Roll out</button></li></ul>'); 90 equal(suspiciousCommit.innerHTML, 91 '<div class="description">' + 92 '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' + 93 '<span class="title">title</span>' + 94 '<span class="author">author</span>' + 95 '<span class="reviewer">reviewer</span>' + 96 '</div>' + 97 '<ul class="actions">' + 98 '<li><button>Roll out</button></li>' + 99 '</ul>'); 91 100 }); 92 101 … … 187 196 '<li>' + 188 197 '<div class="description">' + 189 '<a href="">1</a>title author (reviewer)'+ 198 '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' + 199 '<span class="title">title</span>' + 200 '<span class="author">author</span>' + 201 '<span class="reviewer">reviewer</span>' + 190 202 '</div>' + 191 203 '<ul class="actions">' + … … 224 236 '<li>' + 225 237 '<div class="description">' + 226 '<a href="">1</a>title author (reviewer)'+ 238 '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' + 239 '<span class="title">title</span>' + 240 '<span class="author">author</span>' + 241 '<span class="reviewer">reviewer</span>' + 227 242 '</div>' + 228 243 '<ul class="actions">' + … … 266 281 '<li>' + 267 282 '<div class="description">' + 268 '<a href="">1</a>title author (reviewer)'+ 283 '<a href="http://trac.webkit.org/changeset/1" target="_blank">1</a>' + 284 '<span class="title">title</span>' + 285 '<span class="author">author</span>' + 286 '<span class="reviewer">reviewer</span>' + 269 287 '</div>' + 270 288 '<ul class="actions">' + -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css
r93906 r93926 27 27 font-family: 'Open Sans'; 28 28 font-size: 14px; 29 } 30 31 a { 32 color: #333; 29 33 } 30 34 -
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css
r93906 r93926 73 73 ol.notifications ul.causes>li { 74 74 border-top: 1px solid LightGray; 75 padding: 10px ;75 padding: 10px 20px 10px 0; 76 76 } 77 77 … … 79 79 padding: 0 10px 0 0; 80 80 } 81 82 ol.notifications>li ul.causes>li>div.description>a { 83 padding: 0 20px 0 10px; 84 border-radius: 4px; 85 } 86 87 ol.notifications>li ul.causes>li:hover>div.description>a { 88 background-color: #555; 89 padding: 5px 10px 5px 10px; 90 margin: 0 10px 0 0; 91 color: White; 92 } 93 94 ol.notifications>li ul.causes>li:hover>div.description>a::after { 95 content: ''; 96 width: 0; 97 height: 0; 98 margin-top: 5px; 99 position: absolute; 100 margin-left: 10px; 101 border-top: 5px solid White; 102 border-left: 5px solid #555; 103 border-bottom: 5px solid White; 104 } 105 106 ol.notifications>li ul.causes>li>div.description>span { 107 padding: 0 10px 0 0; 108 display: inline-block; 109 } 110 111 ol.notifications>li ul.causes>li>div.description>span.reviewer { 112 color: Gray; 113 } 114 115 ol.notifications>li ul.causes>li>div.description>span.reviewer::before { 116 content: '('; 117 } 118 119 ol.notifications>li ul.causes>li>div.description>span.reviewer::after { 120 content: ')'; 121 } 81 122 82 123 ol.notifications>li ul.causes>li>ul.actions { -
trunk/Tools/ChangeLog
r93917 r93926 1 2011-08-26 Dimitri Glazkov <dglazkov@chromium.org> 2 3 garden-o-matic summary view should have pretty commit data information. 4 https://bugs.webkit.org/show_bug.cgi?id=67069 5 6 Reviewed by Adam Barth. 7 8 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data. 9 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests. 10 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color. 11 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data. 12 1 13 2011-08-26 Dimitri Glazkov <dglazkov@chromium.org> 2 14
Note: See TracChangeset
for help on using the changeset viewer.