Changeset 94380 in webkit

Timestamp:

Sep 1, 2011 6:35:10 PM (13 years ago)

Author:

gyuyoung.kim@samsung.com

Message:

[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
​https://bugs.webkit.org/show_bug.cgi?id=67012

Reviewed by Kenneth Russell.

Set default minimum DOMTimer interval to 4ms instead of 10ms. Because, 4ms is known
to better minimum value for performance. Mac, android, chromium and window ports already
use 4ms instead of 10ms.

It is desirable to be able to change the minimum DOMTimer interval on per-page basis
in order to avoid consuming excessive CPU and battery life on mobile devices. In addition,
other ports have already used this setting by means of Bug 54312.

• ewk/ewk_main.cpp:

(_ewk_init_body):

• ewk/ewk_settings.cpp:

(ewk_settings_default_timer_interval_get):

• ewk/ewk_settings.h:
• ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_minimum_timer_interval_get):

• ewk/ewk_view.h:

Location:

trunk/Source/WebKit/efl

Files:

• ChangeLog (modified) (1 diff)
• ewk/ewk_main.cpp (modified) (1 diff)
• ewk/ewk_settings.cpp (modified) (1 diff)
• ewk/ewk_settings.h (modified) (1 diff)
• ewk/ewk_view.cpp (modified) (4 diffs)
• ewk/ewk_view.h (modified) (1 diff)

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-09-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        [EFL] Allow controlling minimum DOMTimer interval on a per-page basis
+        https://bugs.webkit.org/show_bug.cgi?id=67012
+
+        Reviewed by Kenneth Russell.
+
+        Set default minimum DOMTimer interval to 4ms instead of 10ms. Because, 4ms is known
+        to better minimum value for performance. Mac, android, chromium and window ports already
+        use 4ms instead of 10ms.
+
+        It is desirable to be able to change the minimum DOMTimer interval on per-page basis
+        in order to avoid consuming excessive CPU and battery life on mobile devices. In addition,
+        other ports have already used this setting by means of Bug 54312.
+
+        * ewk/ewk_main.cpp:
+        (_ewk_init_body):
+        * ewk/ewk_settings.cpp:
+        (ewk_settings_default_timer_interval_get):
+        * ewk/ewk_settings.h:
+        * ewk/ewk_view.cpp:
+        (_ewk_view_priv_new):
+        (ewk_view_setting_minimum_timer_interval_set):
+        (ewk_view_setting_minimum_timer_interval_get):
+        * ewk/ewk_view.h:
+
 2011-09-01  KwangHyuk Kim  <hyuki.kim@samsung.com>
 

trunk/Source/WebKit/efl/ewk/ewk_main.cpp

@@ -162 +162 @@
     WebCore::ScriptController::initializeThreading();
     WebCore::InitializeLoggingChannelsIfNecessary();
+    WebCore::Settings::setDefaultMinDOMTimerInterval(0.004);
 
     // Page cache capacity (in pages). Comment from Mac port:

trunk/Source/WebKit/efl/ewk/ewk_settings.cpp

@@ -279 +279 @@
 #endif
 }
+
+double ewk_settings_default_timer_interval_get(void)
+{
+    return WebCore::Settings::defaultMinDOMTimerInterval();
+}

trunk/Source/WebKit/efl/ewk/ewk_settings.h

@@ -195 +195 @@
 EAPI void             ewk_settings_repaint_throttling_set(double deferred_repaint_delay, double initial_deferred_repaint_delay_during_loading, double max_deferred_repaint_delay_during_loading, double deferred_repaint_delay_increment_during_loading);
 
+/**
+ * Gets the default interval for DOMTimers on all pages.
+ *
+ * DOMTimer processes javascript function registered by setInterval() based on interval value.
+ *
+ * @return default minimum interval for DOMTimers
+ */
+EAPI double           ewk_settings_default_timer_interval_get(void);
+
 #ifdef __cplusplus
 }

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -57 +57 @@
 #include <eina_safety_checks.h>
 #include <inttypes.h>
+#include <limits>
+#include <math.h>
 #include <sys/time.h>
 
@@ -150 +152 @@
         } zoom_range;
         float device_pixel_ratio;
+        double dom_timer_interval;
     } settings;
     struct {
@@ -656 +659 @@
     priv->settings.device_pixel_ratio = DEVICE_PIXEL_RATIO;
 
+    priv->settings.dom_timer_interval = priv->page_settings->defaultMinDOMTimerInterval();
+
     priv->main_frame = _ewk_view_core_frame_new(sd, priv, 0).get();
     if (!priv->main_frame) {
@@ -2332 +2337 @@
 }
 
+Eina_Bool ewk_view_setting_minimum_timer_interval_set(Evas_Object *o, double interval)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
+    if (fabs(priv->settings.dom_timer_interval - interval) >= std::numeric_limits<double>::epsilon()) {
+        priv->page_settings->setMinDOMTimerInterval(interval);
+        priv->settings.dom_timer_interval = interval;
+    }
+    return EINA_TRUE;
+}
+
+double ewk_view_setting_minimum_timer_interval_get(const Evas_Object *o)
+{
+    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
+    return priv->settings.dom_timer_interval;
+}
+
 Ewk_View_Smart_Data *ewk_view_smart_data_get(const Evas_Object *o)
 {

trunk/Source/WebKit/efl/ewk/ewk_view.h

@@ -1811 +1811 @@
 
 /**
+ * Sets the minimum interval for DOMTimers on current page.
+ *
+ * @param o view object to set the minimum interval
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool    ewk_view_setting_minimum_timer_interval_set(Evas_Object *o, double interval);
+
+/**
+ * Gets the minimum interval for DOMTimers on current page.
+ *
+ * @param o view object to get the minimum interval
+ *
+ * @return the minimum interval on success or @c 0 on failure
+ */
+EAPI double       ewk_view_setting_minimum_timer_interval_get(const Evas_Object *o);
+
+/**
  * Gets the internal data of @a o.
  *