Changeset 94485 in webkit

Timestamp:

Sep 3, 2011 1:25:33 AM (13 years ago)

Author:

abarth@webkit.org

Message:

garden-o-matic shows "ghost" failures that are already fixed
​https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com. This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine. That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js

@@ -125 +125 @@
 };
 
+base.parseJSONP = function(jsonp)
+{
+    var startIndex = jsonp.indexOf('(') + 1;
+    var endIndex = jsonp.lastIndexOf(')');
+    return JSON.parse(jsonp.substr(startIndex, endIndex - startIndex));
+}
+
 base.RequestTracker = function(requestsInFlight, callback, args)
 {

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js

@@ -116 +116 @@
 }
 
-/*
-    Assumes SVN-style, consecutive revision scheme.
-*/
 model.commitDataListForRevisionRange = function(fromRevision, toRevision)
 {

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js

@@ -31 +31 @@
 var kTestResultsQuery = kTestResultsServer + 'testfile?'
 var kTestType = 'layout-tests';
-var kResultsName = 'full_results.json';
 var kMasterName = 'ChromiumWebkit';
 
 var kLayoutTestResultsServer = 'http://build.chromium.org/f/chromium/layout_test_results/';
 var kLayoutTestResultsPath = '/results/layout-test-results/';
+var kResultsName = 'full_results.json';
 
 var PASS = 'PASS';
@@ -176 +176 @@
 };
 
-function resultsSummaryURL(builderName, testName)
-{
-    return kTestResultsQuery + $.param(resultsParameters(builderName, testName));
+function resultsSummaryURL(builderName, resultsName)
+{
+    return resultsDirectoryURL(builderName) + resultsName;
 }
 
@@ -537 +537 @@
 results.fetchResultsForBuilder = function(builderName, callback)
 {
-    net.jsonp(resultsSummaryURL(builderName, kResultsName), function(resultsTree) {
-        callback(resultsTree);
+    net.get(resultsSummaryURL(builderName, kResultsName), function(jsonp) {
+        callback(base.parseJSONP(jsonp));
     });
 };

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-03  Adam Barth  <abarth@webkit.org>
+
+        garden-o-matic shows "ghost" failures that are already fixed
+        https://bugs.webkit.org/show_bug.cgi?id=67535
+
+        Reviewed by Eric Seidel.
+
+        About 10% of writes fail to stick on test-results.appspot.com.  This
+        patch causes us to fetch the full_results.json blob directly from
+        build.chromium.org rather than relying upon AppEngine.
+
+        Unforuntately, we still need to get historical information from
+        AppEngine.  That will take several patches to fix becuase I need to
+        change the bots to write the full_results.json file to the
+        build-specific directory in addition to the zip file.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
+
 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>