Changeset 94536 in webkit


Ignore:
Timestamp:
Sep 5, 2011 9:55:52 AM (13 years ago)
Author:
jknotten@chromium.org
Message:

Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Source/WebCore:

Reviewed by Dimitri Glazkov.

Test: fast/events/page-scaled-mouse-click.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

Mouse-related events currently take account of the zoom factor, but they
also need to take account of the page scale factor so that pageX and pageY
event coordinates are properly determined.

Reviewed by Dimitri Glazkov.

  • fast/events/page-scaled-mouse-click-expected.txt: Added.
  • fast/events/page-scaled-mouse-click.html: Added.
  • fast/events/script-tests/page-scaled-mouse-click.js: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r94535 r94536  
     12011-09-05  John Knottenbelt  <jknotten@chromium.org>
     2
     3        Take pageScaleFactor into account for MouseRelatedEvents.
     4        https://bugs.webkit.org/show_bug.cgi?id=67592
     5
     6        Mouse-related events currently take account of the zoom factor, but they
     7        also need to take account of the page scale factor so that pageX and pageY
     8        event coordinates are properly determined.
     9
     10        Reviewed by Dimitri Glazkov.
     11
     12        * fast/events/page-scaled-mouse-click-expected.txt: Added.
     13        * fast/events/page-scaled-mouse-click.html: Added.
     14        * fast/events/script-tests/page-scaled-mouse-click.js: Added.
     15
    1162011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
    217
  • trunk/Source/WebCore/ChangeLog

    r94532 r94536  
     12011-09-05  John Knottenbelt  <jknotten@chromium.org>
     2
     3        Take pageScaleFactor into account for MouseRelatedEvents.
     4        https://bugs.webkit.org/show_bug.cgi?id=67592
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Test: fast/events/page-scaled-mouse-click.html
     9
     10        * dom/MouseRelatedEvent.cpp:
     11        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
     12
    1132011-09-02  Pavel Podivilov  <podivilov@chromium.org>
    214
  • trunk/Source/WebCore/dom/MouseRelatedEvent.cpp

    r93053 r94536  
    6868            scrollPosition = frameView->scrollPosition();
    6969            adjustedPageLocation = frameView->windowToContents(windowLocation);
    70             float pageZoom = frame->pageZoomFactor();
     70            float pageZoom = frame->pageZoomFactor() * frame->pageScaleFactor();
    7171            if (pageZoom != 1.0f) {
    7272                // Adjust our pageX and pageY to account for the page zoom.
Note: See TracChangeset for help on using the changeset viewer.