Changeset 94637 in webkit

Timestamp:

Sep 6, 2011 9:43:33 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
​https://bugs.webkit.org/show_bug.cgi?id=67681

Reviewed by Kent Tamura.

Source/WebCore:

The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called.
Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance.

Test: fast/forms/suggested-value-after-setvalue.html

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):

LayoutTests:

Added a test that overrides the suggested value by modifying the value IDL attribute of an input element.

• fast/forms/suggested-value-after-setvalue-expected.txt: Added.
• fast/forms/suggested-value-after-setvalue.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt (added)
• LayoutTests/fast/forms/suggested-value-after-setvalue.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLInputElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
+        https://bugs.webkit.org/show_bug.cgi?id=67681
+
+        Reviewed by Kent Tamura.
+
+        Added a test that overrides the suggested value by modifying the value IDL attribute of an input element.
+
+        * fast/forms/suggested-value-after-setvalue-expected.txt: Added.
+        * fast/forms/suggested-value-after-setvalue.html: Added.
+
 2011-09-06  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-06  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
+        https://bugs.webkit.org/show_bug.cgi?id=67681
+
+        Reviewed by Kent Tamura.
+
+        The bug was caused by HTMLInputElement::setValue's not clearing m_suggestedValue before updateInnerTextValue is called.
+        Since updateInnerTextValue uses the suggested value when one is present, we need to clear m_suggestedValue in advance.
+
+        Test: fast/forms/suggested-value-after-setvalue.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::setValue):
+
 2011-09-06  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/html/HTMLInputElement.cpp

@@ -1103 +1103 @@
     setNeedsValidityCheck();
 
+    m_suggestedValue = String(); // updateInnerTextValue uses the suggested value.
     if (valueChanged)
         updateInnerTextValue();
@@ -1112 +1113 @@
         else
             cacheSelection(max, max, SelectionHasNoDirection);
-        m_suggestedValue = String();
     }