Changeset 94757 in webkit

Timestamp:

Sep 8, 2011 6:52:04 AM (13 years ago)

Author:

abecsi@webkit.org

Message:

[Qt] Build fails with strict compiler
​https://bugs.webkit.org/show_bug.cgi?id=67778

Reviewed by Csaba Osztrogonác.

Source/ThirdParty/ANGLE:

• src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex

to suppress warning and fix the build when using [-Werror=unused-result]

Source/WebCore:

No new tests needed.

• platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].

Location:

trunk/Source

Files:

• ThirdParty/ANGLE/ChangeLog (modified) (1 diff)
• ThirdParty/ANGLE/src/compiler/glslang_lex.cpp (modified) (3 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/TiledBackingStore.cpp (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2011-09-08  Andras Becsi  <andras.becsi@nokia.com>
+
+        [Qt] Build fails with strict compiler
+        https://bugs.webkit.org/show_bug.cgi?id=67778
+
+        Reviewed by Csaba Osztrogonác.
+
+        * src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex
+        to suppress warning and fix the build when using [-Werror=unused-result]
+
 2011-08-12  Mark Rowe  <mrowe@apple.com>
 

trunk/Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp

@@ -860 +860 @@
 void yyset_lineno (int line_number ,yyscan_t yyscanner );
 
+int yyget_column  (yyscan_t yyscanner );
+
+void yyset_column (int column_no ,yyscan_t yyscanner );
+
 YYSTYPE * yyget_lval (yyscan_t yyscanner );
 
@@ -910 +914 @@
  * we now use fwrite().
  */
-#define ECHO fwrite( yytext, yyleng, 1, yyout )
+#define ECHO do { if (fwrite( yytext, yyleng, 1, yyout )) {} } while (0)
 #endif
 
@@ -921 +925 @@
                 { \
                 int c = '*'; \
-                int n; \
+                unsigned n; \
                 for ( n = 0; n < max_size && \
                              (c = getc( yyin )) != EOF && c != '\n'; ++n ) \

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-08  Andras Becsi  <andras.becsi@nokia.com>
+
+        [Qt] Build fails with strict compiler
+        https://bugs.webkit.org/show_bug.cgi?id=67778
+
+        Reviewed by Csaba Osztrogonác.
+
+        No new tests needed.
+
+        * platform/graphics/TiledBackingStore.cpp:
+        (WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
+        which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].
+
 2011-09-08  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

@@ -341 +341 @@
 bool TiledBackingStore::resizeEdgeTiles()
 {
-    IntRect contentsRect = this->contentsRect();
     bool wasResized = false;