Changeset 94869 in webkit

Timestamp:

Sep 9, 2011 11:37:05 AM (13 years ago)

Author:

adamk@chromium.org

Message:

Initialize ExceptionCode in Element::removeAttribute
​https://bugs.webkit.org/show_bug.cgi?id=67820

Reviewed by Darin Adler.

Silences valgrind warning reported in ​http://crbug.com/76490.

No new tests since this would only very occasionally be flaky,
and in the codepath in the valgrind report, the ec is ignored anyway.

• dom/Element.cpp:

(WebCore::Element::removeAttribute): Initialize ec to 0.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-09  Adam Klein  <adamk@chromium.org>
+
+        Initialize ExceptionCode in Element::removeAttribute
+        https://bugs.webkit.org/show_bug.cgi?id=67820
+
+        Reviewed by Darin Adler.
+
+        Silences valgrind warning reported in http://crbug.com/76490.
+
+        No new tests since this would only very occasionally be flaky,
+        and in the codepath in the valgrind report, the ec is ignored anyway.
+
+        * dom/Element.cpp:
+        (WebCore::Element::removeAttribute): Initialize ec to 0.
+
 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1521 +1521 @@
 
     if (m_attributeMap) {
+        ec = 0;
         m_attributeMap->removeNamedItem(localName, ec);
         if (ec == NOT_FOUND_ERR)