Changeset 95045 in webkit

Timestamp:

Sep 13, 2011 2:43:13 PM (13 years ago)

Author:

abarth@webkit.org

Message:

[Chromium] The checked state of WebPopupMenuItem isn't initialized
​https://bugs.webkit.org/show_bug.cgi?id=67889

Reviewed by Darin Fisher.

It seems we're failing to initialize the checked state of
WebPopupMenuItems, potentially because Android is the first platform to
use popup menus for <select> elements.

• src/ExternalPopupMenu.cpp:

(WebKit::ExternalPopupMenu::getPopupMenuInfo):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/ExternalPopupMenu.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-13  Adam Barth  <abarth@webkit.org>
+
+        [Chromium] The checked state of WebPopupMenuItem isn't initialized
+        https://bugs.webkit.org/show_bug.cgi?id=67889
+
+        Reviewed by Darin Fisher.
+
+        It seems we're failing to initialize the checked state of
+        WebPopupMenuItems, potentially because Android is the first platform to
+        use popup menus for <select> elements.
+
+        * src/ExternalPopupMenu.cpp:
+        (WebKit::ExternalPopupMenu::getPopupMenuInfo):
+
 2011-09-13  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebKit/chromium/src/ExternalPopupMenu.cpp

@@ -174 +174 @@
             popupItem.type = WebMenuItemInfo::Option;
         popupItem.enabled = m_popupMenuClient->itemIsEnabled(i);
+        popupItem.checked = m_popupMenuClient->itemIsSelected(i);
         PopupMenuStyle style = m_popupMenuClient->itemStyle(i);
         if (style.textDirection() == WebCore::RTL)