Changeset 95068 in webkit


Ignore:
Timestamp:
Sep 13, 2011 6:23:14 PM (13 years ago)
Author:
abarth@webkit.org
Message:

FailureGrid in garden-o-matic should link to the builder's waterfall page
​https://bugs.webkit.org/show_bug.cgi?id=68036

Reviewed by Dimitri Glazkov.

One of the users in the user study thought the configurations names in
the failure grid would link to the underlying bots. That makes sense,
so this patch adds the behavior.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
Location:
trunk/Tools
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js

    r94308 r95068  
    3131var kBuildingResult = 'BUILDING';
    3232
    33 ui.failures.Configuration = base.extends('div', {
     33ui.failures.Configuration = base.extends('a', {
    3434    init: function(configuration)
    3535    {
    … …  
    3939            this._addSpan('version', configuration.version);
    4040        this._configuration = configuration;
     41        this.target = '_blank';
    4142    },
    4243    _addSpan: function(className, text)
    … …  
    108109            if (cellContainsConfiguration(cell, configuration))
    109110                return;
    110             cell.appendChild(new ui.failures.Configuration(configuration));
     111            cell.appendChild(new ui.failures.Configuration(configuration)).href = ui.displayURLForBuilder(builderName);
    111112        }, this);
    112113    }

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js

    r94309 r95068  
    3636    configuration = new ui.failures.Configuration({});
    3737    deepEqual(Object.getOwnPropertyNames(configuration.__proto__), ['init', 'equals', '_addSpan']);
    38     equal(configuration.outerHTML, '<div></div>');
     38    equal(configuration.outerHTML, '<a target="_blank"></a>');
    3939    configuration = new ui.failures.Configuration({is64bit: true, version: 'lucid'});
    40     equal(configuration.outerHTML, '<div><span class="architecture">64-bit</span><span class="version">lucid</span></div>');
     40    equal(configuration.outerHTML, '<a target="_blank"><span class="architecture">64-bit</span><span class="version">lucid</span></a>');
    4141    configuration = new ui.failures.Configuration({version: 'xp'});
    42     equal(configuration.outerHTML, '<div><span class="version">xp</span></div>');
     42    equal(configuration.outerHTML, '<a target="_blank"><span class="version">xp</span></a>');
    4343    configuration._addSpan('foo', 'bar');
    44     equal(configuration.outerHTML, '<div><span class="version">xp</span><span class="foo">bar</span></div>');
     44    equal(configuration.outerHTML, '<a target="_blank"><span class="version">xp</span><span class="foo">bar</span></a>');
    4545    ok(configuration.equals({version: 'xp'}));
    4646    ok(!configuration.equals({version: 'lucid',is64bit: true}));
    … …  
    8585                '<td>TEXT</td>' +
    8686                '<td></td>' +
    87                 '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
     87                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
    8888            '</tr>' +
    8989            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
    … …  
    9696            '<tr class="IMAGE+TEXT">' +
    9797                '<td>IMAGE+TEXT</td>' +
    98                 '<td><div><span class="version">leopard</span></div></td>' +
     98                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span></a></td>' +
    9999                '<td></td>' +
    100100            '</tr>' +
    … …  
    102102                '<td>TEXT</td>' +
    103103                '<td></td>' +
    104                 '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
     104                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
    105105            '</tr>' +
    106106            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
    … …  
    113113            '<tr class="IMAGE+TEXT">' +
    114114                '<td>IMAGE+TEXT</td>' +
    115                 '<td><div><span class="version">leopard</span></div></td>' +
     115                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span></a></td>' +
    116116                '<td></td>' +
    117117            '</tr>' +
    … …  
    119119                '<td>TEXT</td>' +
    120120                '<td></td>' +
    121                 '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
     121                '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
    122122            '</tr>' +
    123123            '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js

    r95067 r95068  
    218218                        '<td>TEXT</td>' +
    219219                        '<td></td>' +
    220                         '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
     220                        '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
    221221                    '</tr>' +
    222222                    '<tr class="BUILDING" style="display: none; "><td>BUILDING</td><td></td><td></td></tr>' +
    … …  
    262262                        '<td>TEXT</td>' +
    263263                        '<td></td>' +
    264                         '<td><div><span class="architecture">64-bit</span><span class="version">lucid</span></div></td>' +
     264                        '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+(dbg)(1)"><span class="architecture">64-bit</span><span class="version">lucid</span></a></td>' +
    265265                    '</tr>' +
    266266                    '<tr class="BUILDING" style="">' +
    267267                        '<td>BUILDING</td>' +
    268                         '<td><div><span class="version">leopard</span></div></td>' +
     268                        '<td><a target="_blank" href="http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Mac10.5+(CG)"><span class="version">leopard</span></a></td>' +
    269269                        '<td></td>' +
    270270                    '</tr>' +

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css

    r94314 r95068  
    186186    }
    187187
    188     ol.notifications table.failures tbody td:nth-child(n+2)>div {
     188    ol.notifications table.failures tbody td:nth-child(n+2)>a {
    189189        display: inline-block;
    190190        border: 1px solid Gray;
    191191        margin: 0 0 2px 0;
    192192        padding: 1px;
    193     }
    194 
    195         ol.notifications table.failures tbody td:nth-child(n+2)>div>span.version {
     193        color: Black;
     194        text-decoration: none;
     195    }
     196
     197        ol.notifications table.failures tbody td:nth-child(n+2)>a>span.version {
    196198            text-transform: uppercase;
    197199            background-color: #555;
    … …  
    200202        }
    201203
    202         ol.notifications table.failures tbody td:nth-child(n+2)>div>span.architecture {
     204        ol.notifications table.failures tbody td:nth-child(n+2)>a>span.architecture {
    203205            padding: 0 3px 0 0;
    204206        }

  • trunk/Tools/ChangeLog

    r95067 r95068  
     12011-09-13  Adam Barth  <abarth@webkit.org>
     2
     3        FailureGrid in garden-o-matic should link to the builder's waterfall page
     4        https://bugs.webkit.org/show_bug.cgi?id=68036
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        One of the users in the user study thought the configurations names in
     9        the failure grid would link to the underlying bots.  That makes sense,
     10        so this patch adds the behavior.
     11
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
     13        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
     14        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
     15        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
     16
    1172011-09-13  Adam Barth  <abarth@webkit.org>
    218
Note: See TracChangeset for help on using the changeset viewer.