Changeset 95169 in webkit

Timestamp:

Sep 14, 2011 10:26:45 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

libxml2 fragment parser loses prefix namespaces
​https://bugs.webkit.org/show_bug.cgi?id=66423

Source/WebCore:

This makes the loop over the elements outside of the context actually update the element it's processing.

Patch by Jeffrey Pfau <​jeffrey@endrift.com> on 2011-09-14
Reviewed by Eric Seidel.

Test: fast/parser/innerhtml-with-prefixed-elements.xhtml

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.

Patch by Jeffrey Pfau <​jeffrey@endrift.com> on 2011-09-14
Reviewed by Eric Seidel.

• fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
• platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
• platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/innerhtml-with-prefixed-elements.xhtml (added)
• LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png (added)
• LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-14  Jeffrey Pfau  <jeffrey@endrift.com>
+
+        libxml2 fragment parser loses prefix namespaces
+        https://bugs.webkit.org/show_bug.cgi?id=66423
+
+        Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.
+
+        Reviewed by Eric Seidel.
+
+        * fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
+        * platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
+        * platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
+
 2011-09-14  Keishi Hattori  <keishi@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-14  Jeffrey Pfau  <jeffrey@endrift.com>
+
+        libxml2 fragment parser loses prefix namespaces
+        https://bugs.webkit.org/show_bug.cgi?id=66423
+
+        This makes the loop over the elements outside of the context actually update the element it's processing.
+
+        Reviewed by Eric Seidel.
+
+        Test: fast/parser/innerhtml-with-prefixed-elements.xhtml
+
+        * xml/parser/XMLDocumentParserLibxml2.cpp:
+        (WebCore::XMLDocumentParser::XMLDocumentParser):
+
 2011-09-14  Nate Chapin  <japhet@chromium.org>
 

trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp

@@ -611 +611 @@
         return;
 
-    for (Element* element = elemStack.last(); !elemStack.isEmpty(); elemStack.removeLast()) {
+    for (; !elemStack.isEmpty(); elemStack.removeLast()) {
+        Element* element = elemStack.last();
         if (NamedNodeMap* attrs = element->attributes()) {
             for (unsigned i = 0; i < attrs->length(); i++) {