Changeset 95256 in webkit


Ignore:
Timestamp:
Sep 15, 2011 6:54:35 PM (13 years ago)
Author:
enne@google.com
Message:

[chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
https://bugs.webkit.org/show_bug.cgi?id=68204

Reviewed by James Robinson.

Add CRASH calls to determine which assumptions are being violated.

Source/WebCore:

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::commitTo):

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::composite):

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r95250 r95256  
     12011-09-15  Adrienne Walker  <enne@google.com>
     2
     3        [chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
     4        https://bugs.webkit.org/show_bug.cgi?id=68204
     5
     6        Reviewed by James Robinson.
     7
     8        Add CRASH calls to determine which assumptions are being violated.
     9
     10        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
     11        (WebCore::CCLayerTreeHost::commitTo):
     12
    1132011-09-15  Mark Hahnenberg  <mhahnenberg@apple.com>
    214
  • trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp

    r95152 r95256  
    113113    hostImpl->setSourceFrameNumber(frameNumber());
    114114
     115    // FIXME: Temporary diagnostic for crbug 96719. This shouldn't happen.
     116    if (!contentsTextureManager())
     117        CRASH();
     118
    115119    contentsTextureManager()->reduceMemoryToLimit(TextureManager::reclaimLimitBytes());
    116120    contentsTextureManager()->deleteEvictedTextures(hostImpl->context());
  • trunk/Source/WebKit/chromium/ChangeLog

    r95255 r95256  
     12011-09-15  Adrienne Walker  <enne@google.com>
     2
     3        [chromium] Add temporary diagnostics for LayerTreeHost::commitTo crash
     4        https://bugs.webkit.org/show_bug.cgi?id=68204
     5
     6        Reviewed by James Robinson.
     7
     8        Add CRASH calls to determine which assumptions are being violated.
     9
     10        * src/WebViewImpl.cpp:
     11        (WebKit::WebViewImpl::composite):
     12
    1132011-09-15  David Levin  <levin@chromium.org>
    214
  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r95252 r95256  
    11711171        m_pageOverlay->update();
    11721172
     1173    // FIXME: Temporary diagnostic for crbug 96719. This shouldn't happen.
     1174    if (!m_layerTreeHost)
     1175        CRASH();
     1176
    11731177    m_layerTreeHost->composite();
    11741178#endif
Note: See TracChangeset for help on using the changeset viewer.