Changeset 95446 in webkit

Timestamp:

Sep 19, 2011 11:29:27 AM (13 years ago)

Author:

alexis.menard@openbossa.org

Message:

Style checker should not check public Qt WK2 API for parameter_name.
​https://bugs.webkit.org/show_bug.cgi?id=68359

Reviewed by Andreas Kling.

The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
Add an exception in the style checker to disable the check. Also added the test for it.

• Scripts/webkitpy/style/checker.py:
• Scripts/webkitpy/style/checker_unittest.py:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/checker.py (modified) (1 diff)
• Scripts/webkitpy/style/checker_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
+
+        Style checker should not check public Qt WK2 API for parameter_name.
+        https://bugs.webkit.org/show_bug.cgi?id=68359
+
+        Reviewed by Andreas Kling.
+
+        The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
+        Add an exception in the style checker to disable the check. Also added the test for it.
+
+        * Scripts/webkitpy/style/checker.py:
+        * Scripts/webkitpy/style/checker_unittest.py:
+
 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
 

trunk/Tools/Scripts/webkitpy/style/checker.py

@@ -145 +145 @@
        "Tools/MiniBrowser/qt"],
       ["-build/include"]),
+
+    ([# The Qt APIs use Qt/QML naming style, which includes
+      # naming parameters in h files.
+      "Source/WebKit2/UIProcess/API/qt"],
+     ["-readability/parameter_name"]),
+
     ([# The GTK+ APIs use GTK+ naming style, which includes
       # lower-cased, underscore-separated values, whitespace before

trunk/Tools/Scripts/webkitpy/style/checker_unittest.py

@@ -258 +258 @@
                     "build/include")
 
+        assertNoCheck("Source/WebKit2/UIProcess/API/qt",
+                    "readability/parameter_name")
+
         assertNoCheck("Source/WebCore/ForwardingHeaders/debugger/Debugger.h",
                       "build/header_guard")