Changeset 95571 in webkit

Timestamp:

Sep 20, 2011 2:59:44 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[CSSRegions] Need test case for 66198 (sliced line box rendering)
​https://bugs.webkit.org/show_bug.cgi?id=68257

Patch by Alan Stearns <​stearns@adobe.com> on 2011-09-20
Reviewed by David Hyatt.

• fast/regions/resources/helper.js:

(assertTopLeftMatch):
(sameTopLeft):

• fast/regions/no-split-line-box-expected.txt: Added.
• fast/regions/no-split-line-box.html: Added.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/regions/no-split-line-box-expected.txt (added)
• fast/regions/no-split-line-box.html (added)
• fast/regions/resources/helper.js (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-20  Alan Stearns  <stearns@adobe.com>
+
+        [CSSRegions] Need test case for 66198 (sliced line box rendering)
+        https://bugs.webkit.org/show_bug.cgi?id=68257
+
+        Reviewed by David Hyatt.
+
+        * fast/regions/resources/helper.js:
+        (assertTopLeftMatch):
+        (sameTopLeft):
+        * fast/regions/no-split-line-box-expected.txt: Added.
+        * fast/regions/no-split-line-box.html: Added.
+
 2011-09-20  David Hyatt  <hyatt@apple.com>
 

trunk/LayoutTests/fast/regions/resources/helper.js

@@ -5 +5 @@
 }
 
-function rectToArray(rect) {
+function rectToArray(rect)
+{
     return [rect.top, rect.left, rect.bottom, rect.right, rect.width, rect.height];
 }
 
-function areEqualNumbers(actual, expected, tolerance) {
+function areEqualNumbers(actual, expected, tolerance)
+{
     var diff = Math.abs(actual - expected);
     return diff <= tolerance;
 }
 
-function areEqualRects(r1, r2, tolerance) {
+function areEqualRects(r1, r2, tolerance)
+{
     if (r1.length != r2.length)
         return false;
@@ -25 +28 @@
 }
 
-function assertEqualRects(results, name, actualRect, expectedRect, tolerance) {
+function assertTopLeftMatch (r1, r2, tolerance)
+{
+    if (sameTopLeft(r1, r2, tolerance))
+        return "PASS";
+    return "FAIL. Expected top left points to match, but got ("+ r1.top + "," + r1.left + ") and ("+ r2.top + "," + r2.left + ")";
+}
+
+function sameTopLeft(r1, r2, tolerance)
+{
+    if (tolerance === undefined)
+        tolerance = 0;
+    if ( areEqualNumbers(r1.top, r2.top, tolerance) && areEqualNumbers(r1.left, r2.left, tolerance) )
+        return true;
+    return false;
+}
+
+function assertEqualRects(results, name, actualRect, expectedRect, tolerance)
+{
     if (areEqualRects(actualRect, expectedRect, tolerance))
         return;
@@ -51 +71 @@
 }
 
-function assertRectContains(results, name, containerRect, insideRect, tolerance) {
+function assertRectContains(results, name, containerRect, insideRect, tolerance)
+{
     // make the container rect bigger with tolerance
     var left = containerRect.left - tolerance;
@@ -64 +85 @@
 }
 
-function addPageLevelDebugBox(rect, color) {
+function addPageLevelDebugBox(rect, color)
+{
     var el = document.createElement("div");
     el.style.position = "absolute";