Changeset 95668 in webkit

Timestamp:

Sep 21, 2011 1:39:08 PM (13 years ago)

Author:

jamesr@google.com

Message:

[chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
​https://bugs.webkit.org/show_bug.cgi?id=68558

Reviewed by Stephen White.

The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time. This is bad, since
by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
crash. Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
RefPtr<>

• platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::get):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gpu/SharedGraphicsContext3D.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-21  James Robinson  <jamesr@chromium.org>
+
+        [chromium] SharedGraphicsContext3D's context should not be destroyed during atexit
+        https://bugs.webkit.org/show_bug.cgi?id=68558
+
+        Reviewed by Stephen White.
+
+        The SharedGraphicsContext3D's internal context is lazily created and then leaked intentionally, but since the
+        last ref is in a function-static RefPtr<> it ends up being destroyed at process exit time.  This is bad, since
+        by the time we get this far in process shutdown we can't actually cleanly run the destruction logic and we
+        crash.  Since we are explicitly leaking this for the lifetime of the process there's no point in keeping it in a
+        RefPtr<>
+
+        * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+        (WebCore::SharedGraphicsContext3D::get):
+
 2011-09-21  Sergey Glazunov  <serg.glazunov@gmail.com>
 

trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp

@@ -39 +39 @@
     attributes.canRecoverFromContextLoss = false; // Canvas contexts can not handle lost contexts.
     attributes.shareResources = true;
-    static RefPtr<GraphicsContext3D> context = GraphicsContext3D::create(attributes, 0);
-    return context.get();
+    static GraphicsContext3D* context = GraphicsContext3D::create(attributes, 0).leakRef();
+    return context;
 }