Changeset 95767 in webkit

Timestamp:

Sep 22, 2011 5:43:07 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Use ewk_view to navigate in history instead of ewk_history.
​https://bugs.webkit.org/show_bug.cgi?id=68455

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.

BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.

This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.

• DumpRenderTree/efl/WorkQueueItemEfl.cpp:

(BackForwardItem::invoke):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/WorkQueueItemEfl.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Use ewk_view to navigate in history instead of ewk_history.
+        https://bugs.webkit.org/show_bug.cgi?id=68455
+
+        Reviewed by Antonio Gomes.
+
+        BackForwardItem::invoke() was using ewk_history functions to navigate
+        in history; however, this will only call WebCore::BackForwardListImpl
+        and not move between pages at all. We now call ewk_view_navigate and
+        its siblings to make sure the navigation actually happens.
+
+        This should make tests like fast/dom/navigation-type-back-forward.html
+        stop timing out.
+
+        * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
+        (BackForwardItem::invoke):
+
 2011-09-22  Dean Jackson  <dino@apple.com>
 

trunk/Tools/DumpRenderTree/efl/WorkQueueItemEfl.cpp

@@ -24 +24 @@
 
 #include "DumpRenderTree.h"
+#include "DumpRenderTreeChrome.h"
 
 #include <EWebKit.h>
@@ -68 +69 @@
 bool BackForwardItem::invoke() const
 {
-    Ewk_History* history = ewk_view_history_get(browser);
-
     if (m_howFar == 1)
-        ewk_history_forward(history);
+        ewk_view_forward(browser->mainView());
     else if (m_howFar == -1)
-        ewk_history_back(history);
-    else {
-        const Ewk_History_Item* item = ewk_history_history_item_nth_get(history, m_howFar);
-        ewk_history_history_item_set(history, item);
-    }
+        ewk_view_back(browser->mainView());
+    else
+        ewk_view_navigate(browser->mainView(), m_howFar);
 
     return true;