Changeset 95861 in webkit

Timestamp:

Sep 23, 2011 2:48:02 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

occasional crash in Chromium in dispatching keyEvent
​https://bugs.webkit.org/show_bug.cgi?id=67941

Patch by Scott Graham <​scottmg@chromium.org> on 2011-09-23
Reviewed by Darin Fisher.

Use focusedWebCoreNode() to handle null document for frame when
retrieving focused node in handling keyEvent.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::keyEvent):

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebViewImpl.cpp (modified) (1 diff)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-09-23  Scott Graham  <scottmg@chromium.org>
+
+        occasional crash in Chromium in dispatching keyEvent
+        https://bugs.webkit.org/show_bug.cgi?id=67941
+
+        Reviewed by Darin Fisher.
+
+        Use focusedWebCoreNode() to handle null document for frame when
+        retrieving focused node in handling keyEvent.
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::keyEvent):
+
 2011-09-23  Fady Samuel  <fsamuel@chromium.org>
 

trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

@@ -655 +655 @@
             // Suppress the next keypress event unless the focused node is a plug-in node.
             // (Flash needs these keypress events to handle non-US keyboards.)
-            Node* node = frame->document()->focusedNode();
+            Node* node = focusedWebCoreNode();
             if (!node || !node->renderer() || !node->renderer()->isEmbeddedObject())
                 m_suppressNextKeypressEvent = true;