Changeset 95943 in webkit

Timestamp:

Sep 26, 2011 5:15:28 AM (13 years ago)

Author:

Adam Roben

Message:

Remove two failing WebKitAPITest tests

The failures are covered by <​http://webkit.org/b/33162> and <​http://webkit.org/b/32868>.

Reviewed by Anders Carlsson.

• WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and

MainFrameAfterClose tests.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitAPITest/tests/WebViewDestruction.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-23  Adam Roben  <aroben@apple.com>
+
+        Remove two failing WebKitAPITest tests
+
+        The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
+
+        Reviewed by Anders Carlsson.
+
+        * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
+        MainFrameAfterClose tests.
+
 2011-09-25  Adam Barth  <abarth@webkit.org>
 

trunk/Tools/WebKitAPITest/tests/WebViewDestruction.cpp

@@ -115 +115 @@
 }
 
-// Tests that releasing a WebView without calling IWebView::close or DestroyWindow doesn't leak. <http://webkit.org/b/33162>
-TEST(WebViewDestruction, NoCloseOrDestroyViewWindow)
-{
-    COMPtr<IWebView> webView;
-    HostWindow window;
-    HWND viewWindow;
-    createAndInitializeWebView(webView, window, viewWindow);
-
-    finishWebViewDestructionTest(webView, viewWindow);
-}
-
 // Tests that calling IWebView::close without calling DestroyWindow, then releasing a WebView doesn't crash. <http://webkit.org/b/32827>
 TEST(WebViewDestruction, CloseWithoutDestroyViewWindow)
@@ -215 +204 @@
 }
 
-// Tests that calling IWebView::mainFrame after calling IWebView::close doesn't crash. <http://webkit.org/b/32868>
-TEST(WebViewDestruction, MainFrameAfterClose)
-{
-    COMPtr<IWebView> webView;
-    HostWindow window;
-    HWND viewWindow;
-    createAndInitializeWebView(webView, window, viewWindow);
-
-    TEST_ASSERT(SUCCEEDED(webView->close()));
-    COMPtr<IWebFrame> mainFrame;
-    TEST_ASSERT(SUCCEEDED(webView->mainFrame(&mainFrame)));
-
-    finishWebViewDestructionTest(webView, viewWindow);
-}
-
 } // namespace WebKitAPITest