Changeset 95978 in webkit
- Timestamp:
- Sep 26, 2011 12:51:15 PM (13 years ago)
- Location:
- trunk/Source
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r95974 r95978 1 2011-09-26 Jer Noble <jer.noble@apple.com> 2 3 White flash when entering full-screen using element.webkitRequestFullScreen() 4 https://bugs.webkit.org/show_bug.cgi?id=68481 5 6 Reviewed by Simon Fraser. 7 8 No new tests; covered by existing full screen tests. 9 10 During an animation, renderers may try to paint into the FullScreenRenderer's 11 GraphicsLayer, and an optimization we previously added for the FullScreenRenderer's 12 background will cause these paints to fail. Remove this optimization in 13 containsPaintedContent, and taking non-composited elements into full screen will 14 animate correctly. 15 16 * rendering/RenderLayerBacking.cpp: 17 (WebCore::RenderLayerBacking::containsPaintedContent): 18 1 19 2011-09-26 Mihai Parparita <mihaip@chromium.org> 2 20 -
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
r95901 r95978 911 911 return hasBoxDecorationsOrBackground(renderer()); 912 912 #endif 913 #if ENABLE(FULLSCREEN_API)914 if (renderer()->isRenderFullScreen())915 return false;916 #endif917 913 918 914 return true; -
trunk/Source/WebKit2/ChangeLog
r95968 r95978 1 2011-09-26 Jer Noble <jer.noble@apple.com> 2 3 White flash when entering full-screen using element.webkitRequestFullScreen() 4 https://bugs.webkit.org/show_bug.cgi?id=68481 5 6 Reviewed by Simon Fraser. 7 8 Do not re-enable screen updates after exiting compositing mode until a repaint has completed. 9 10 * UIProcess/mac/WKFullScreenWindowController.mm: 11 (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): 12 (continueExitCompositingModeAfterRepaintCallback): 13 (-[WKFullScreenWindowController _continueExitCompositingModeAfterRepaint]): 14 1 15 2011-09-23 Simon Fraser <simon.fraser@apple.com> 2 16 -
trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm
r95901 r95978 76 76 @end 77 77 78 static void continueExitCompositingModeAfterRepaintCallback(WKErrorRef error, void* context); 79 78 80 @interface WKFullScreenWindowController(Private) 79 81 - (void)_requestExitFullScreenWithAnimation:(BOOL)animation; … … 85 87 - (WebPageProxy*)_page; 86 88 - (WebFullScreenManagerProxy*)_manager; 89 - (void)_continueExitCompositingModeAfterRepaint; 87 90 @end 88 91 … … 413 416 414 417 _layerHostingView = 0; 418 [self _page]->forceRepaint(VoidCallback::create(self, continueExitCompositingModeAfterRepaintCallback)); 419 } 420 421 static void continueExitCompositingModeAfterRepaintCallback(WKErrorRef error, void* context) 422 { 423 [(WKFullScreenWindowController*)context _continueExitCompositingModeAfterRepaint]; 424 } 425 426 - (void)_continueExitCompositingModeAfterRepaint 427 { 415 428 NSEnableScreenUpdates(); 416 429
Note: See TracChangeset
for help on using the changeset viewer.