Changeset 96009 in webkit


Ignore:
Timestamp:
Sep 26, 2011 3:28:31 PM (13 years ago)
Author:
xan@webkit.org
Message:

[GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=68837

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm: add getters (but not

setters) for 'Replaceable' attributes. Punt for the future
actually making them settable, since it seems non trivial.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r96008 r96009  
     12011-09-26  Xan Lopez  <xlopez@igalia.com>
     2
     3        [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings
     4        https://bugs.webkit.org/show_bug.cgi?id=68837
     5
     6        Reviewed by Martin Robinson.
     7
     8        * bindings/scripts/CodeGeneratorGObject.pm: add getters (but not
     9        setters) for 'Replaceable' attributes. Punt for the future
     10        actually making them settable, since it seems non trivial.
     11
    1122011-09-26  Ryosuke Niwa  <rniwa@webkit.org>
    213
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

    r95349 r96009  
    156156   
    157157    if ($attribute->signature->extendedAttributes->{"CustomGetter"} ||
    158         $attribute->signature->extendedAttributes->{"CustomSetter"} ||
    159         $attribute->signature->extendedAttributes->{"Replaceable"}) {
     158        $attribute->signature->extendedAttributes->{"CustomSetter"}) {
    160159        return 1;
    161160    }
    162    
     161
    163162    my $propType = $attribute->signature->type;
    164163    if ($propType =~ /Constructor$/) {
     
    308307                                 $gtype eq "uint" || $gtype eq "ushort" || $gtype eq "uchar" ||
    309308                                 $gtype eq "char" || $gtype eq "string");
    310         if ($writeable && $hasGtypeSignature) {
     309        # FIXME: We are not generating setters for 'Replaceable'
     310        # attributes now, but we should somehow.
     311        my $replaceable = $property->signature->extendedAttributes->{"Replaceable"};
     312        if ($writeable && $hasGtypeSignature && !$replaceable) {
    311313            push(@result, $property);
    312314        }
     
    10401042        $function->raisesExceptions($attribute->getterExceptions);
    10411043        $object->GenerateFunction($interfaceName, $function, "get_");
    1042        
    1043         if ($attribute->type =~ /^readonly/) {
     1044
     1045        # FIXME: We are not generating setters for 'Replaceable'
     1046        # attributes now, but we should somehow.
     1047        if ($attribute->type =~ /^readonly/ ||
     1048            $attribute->signature->extendedAttributes->{"Replaceable"}) {
    10441049            next TOP;
    10451050        }
Note: See TracChangeset for help on using the changeset viewer.