Changeset 96009 in webkit
- Timestamp:
- Sep 26, 2011 3:28:31 PM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r96008 r96009 1 2011-09-26 Xan Lopez <xlopez@igalia.com> 2 3 [GTK] Do not ignore 'Replaceable' attributes in the DOM bindings 4 https://bugs.webkit.org/show_bug.cgi?id=68837 5 6 Reviewed by Martin Robinson. 7 8 * bindings/scripts/CodeGeneratorGObject.pm: add getters (but not 9 setters) for 'Replaceable' attributes. Punt for the future 10 actually making them settable, since it seems non trivial. 11 1 12 2011-09-26 Ryosuke Niwa <rniwa@webkit.org> 2 13 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
r95349 r96009 156 156 157 157 if ($attribute->signature->extendedAttributes->{"CustomGetter"} || 158 $attribute->signature->extendedAttributes->{"CustomSetter"} || 159 $attribute->signature->extendedAttributes->{"Replaceable"}) { 158 $attribute->signature->extendedAttributes->{"CustomSetter"}) { 160 159 return 1; 161 160 } 162 161 163 162 my $propType = $attribute->signature->type; 164 163 if ($propType =~ /Constructor$/) { … … 308 307 $gtype eq "uint" || $gtype eq "ushort" || $gtype eq "uchar" || 309 308 $gtype eq "char" || $gtype eq "string"); 310 if ($writeable && $hasGtypeSignature) { 309 # FIXME: We are not generating setters for 'Replaceable' 310 # attributes now, but we should somehow. 311 my $replaceable = $property->signature->extendedAttributes->{"Replaceable"}; 312 if ($writeable && $hasGtypeSignature && !$replaceable) { 311 313 push(@result, $property); 312 314 } … … 1040 1042 $function->raisesExceptions($attribute->getterExceptions); 1041 1043 $object->GenerateFunction($interfaceName, $function, "get_"); 1042 1043 if ($attribute->type =~ /^readonly/) { 1044 1045 # FIXME: We are not generating setters for 'Replaceable' 1046 # attributes now, but we should somehow. 1047 if ($attribute->type =~ /^readonly/ || 1048 $attribute->signature->extendedAttributes->{"Replaceable"}) { 1044 1049 next TOP; 1045 1050 }
Note: See TracChangeset
for help on using the changeset viewer.