Changeset 96180 in webkit


Ignore:
Timestamp:
Sep 27, 2011 7:30:27 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Implement a PageTransitionEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=68067

Patch by Kentaro Hara <​haraken@chromium.com> on 2011-09-27
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/page-transition-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
  • dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.

  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r96179 r96180  
     12011-09-27  Kentaro Hara  <haraken@chromium.com>
     2
     3        Implement a PageTransitionEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=68067
     5
     6        Reviewed by Adam Barth.
     7
     8        Enabled page-transition-event-constructor.html, since now V8 has a PageTransitionEvent constructor.
     9
     10        * platform/chromium/test_expectations.txt:
     11
    1122011-09-27  Kentaro Hara  <haraken@chromium.org>
    213

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r96179 r96180  
    7474// to re-enable these "in the next few weeks".
    7575BUGPKASTING SKIP : animations/animation-api-1.html = TEXT
    76 
    77 // This will soon be fixed after implementing a PageTransitionEvent constructor for V8.
    78 BUGWK68048 : fast/events/constructors/page-transition-event-constructor.html = FAIL
    7976
    8077// Unskip after implementing DRT support for setDefersLoading and goBack.

  • trunk/Source/WebCore/ChangeLog

    r96179 r96180  
     12011-09-27  Kentaro Hara  <haraken@chromium.com>
     2
     3        Implement a PageTransitionEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=68067
     5
     6        Reviewed by Adam Barth.
     7
     8        Test: fast/events/constructors/page-transition-event-constructor.html
     9
     10        * bindings/v8/custom/V8EventConstructors.cpp: Added the PageTransitionEvent constructor.
     11        * dom/PageTransitionEvent.idl: Added a 'V8CustomConstructor' attribute.
     12
    1132011-09-27  Kentaro Hara  <haraken@chromium.org>
    214

  • trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp

    r96061 r96180  
    3838#include "HashChangeEvent.h"
    3939#include "Node.h"
     40#include "PageTransitionEvent.h"
    4041#include "ProgressEvent.h"
    4142#include "WebKitAnimationEvent.h"
    … …  
    5051#include "V8HashChangeEvent.h"
    5152#include "V8Node.h"
     53#include "V8PageTransitionEvent.h"
    5254#include "V8ProgressEvent.h"
    5355#include "V8Proxy.h"
    … …  
    112114INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_HASH_CHANGE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    113115INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CLOSE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
     116INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    114117
    115118

  • trunk/Source/WebCore/dom/PageTransitionEvent.idl

    r95079 r96180  
    2828    interface [
    2929        CanBeConstructed,
    30         CustomConstructFunction
     30        CustomConstructFunction,
     31        V8CustomConstructor
    3132    ] PageTransitionEvent : Event {
    3233
Note: See TracChangeset for help on using the changeset viewer.